From: Fariborz Jahanian Date: Fri, 29 Apr 2011 22:11:28 +0000 (+0000) Subject: removes a meaningless comment. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=73a6f8e8ad2174fb70cfb4c7d7afe424cfe8a147;p=clang removes a meaningless comment. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130550 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CGExprAgg.cpp b/lib/CodeGen/CGExprAgg.cpp index 2f2f7c1fe5..29c76887a7 100644 --- a/lib/CodeGen/CGExprAgg.cpp +++ b/lib/CodeGen/CGExprAgg.cpp @@ -394,7 +394,7 @@ void AggExprEmitter::VisitBinAssign(const BinaryOperator *E) { && "Invalid assignment"); if (const DeclRefExpr *DRE = dyn_cast(E->getLHS())) - if (const VarDecl *VD = dyn_cast(DRE->getDecl())) { + if (const VarDecl *VD = dyn_cast(DRE->getDecl())) if (VD->hasAttr() && E->getRHS()->HasSideEffects(CGF.getContext())) { // When __block variable on LHS, the RHS must be evaluated first @@ -404,12 +404,10 @@ void AggExprEmitter::VisitBinAssign(const BinaryOperator *E) { bool GCollection = false; if (CGF.getContext().getLangOptions().getGCMode()) GCollection = TypeRequiresGCollection(E->getLHS()->getType()); - // Codegen the RHS so that it stores directly into the LHS. Dest = AggValueSlot::forLValue(LHS, true, GCollection); EmitFinalDestCopy(E, RHS, true); return; } - } LValue LHS = CGF.EmitLValue(E->getLHS());