From: Jeremy Hylton <jeremy@alum.mit.edu>
Date: Fri, 9 Nov 2001 19:34:43 +0000 (+0000)
Subject: Fiddle with new test cases -- verify that we get a sensible error
X-Git-Tag: v2.2.1c1~806
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=734c7fb13165e9c299c2522f06da5b31a50af941;p=python

Fiddle with new test cases -- verify that we get a sensible error
message for bad mode argument -- so that it doesn't fail on Windows.

It's hack.  We know that errno is set to 0 in this case on Windows, so
check for that specifically.
---

diff --git a/Lib/test/test_file.py b/Lib/test/test_file.py
index cb1bdce08e..931e33db36 100644
--- a/Lib/test/test_file.py
+++ b/Lib/test/test_file.py
@@ -46,14 +46,17 @@ else:
     print "writelines accepted sequence of non-string objects"
 f.close()
 
-# verify that we get a sensible error message for bad made argument
+# verify that we get a sensible error message for bad mode argument
 bad_mode = "qwerty"
 try:
     open(TESTFN, bad_mode)
 except IOError, msg:
-    s = str(msg)
-    if s.find(TESTFN) != -1 or s.find(bad_mode) == -1:
-        print "bad error message for invalid mode: %s" % s
+    if msg[0] != 0:
+        s = str(msg)
+        if s.find(TESTFN) != -1 or s.find(bad_mode) == -1:
+            print "bad error message for invalid mode: %s" % s
+    # if msg[0] == 0, we're probably on Windows where there may be
+    # no obvious way to discover why open() failed.
 else:
     print "no error for invalid mode: %s" % bad_mode