From: Guido van Rossum <guido@python.org>
Date: Wed, 12 Jun 2002 20:46:49 +0000 (+0000)
Subject: testSetSockOpt() should not require the reuse flag to be 1 -- any
X-Git-Tag: v2.3c1~5366
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=733632ac1f61acc9b96ad316972a71b290e30db0;p=python

testSetSockOpt() should not require the reuse flag to be 1 -- any
nonzero value is OK.  Also fixed the error message for this and for
testGetSockOpt().
---

diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
index 20961f6e81..8649a6b332 100644
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -253,14 +253,14 @@ class GeneralModuleTests(unittest.TestCase):
         # We know a socket should start without reuse==0
         sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
         reuse = sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR)
-        self.assert_(reuse == 0, "Error performing getsockopt.")
+        self.failIf(reuse != 0, "initial mode is reuse")
 
     def testSetSockOpt(self):
         """Testing setsockopt()."""
         sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
         sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
         reuse = sock.getsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR)
-        self.assert_(reuse == 1, "Error performing setsockopt.")
+        self.failIf(reuse == 0, "failed to set reuse mode")
 
 class BasicTCPTest(SocketConnectedTest):