From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 30 Aug 2011 21:15:00 +0000 (-0400)
Subject: Fix not-backwards-compatible pg_upgrade test for prepared transactions.
X-Git-Tag: REL9_2_BETA1~1182
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=731ebb64b77571e1dc391ba96c4bf9c685a07f2a;p=postgresql

Fix not-backwards-compatible pg_upgrade test for prepared transactions.

There's no reason for this test to use the undocumented pg_prepared_xact()
function, when it can use the stable API pg_prepared_xacts instead.
Fixes breakage against 8.3, as reported by Justin Arnold.
---

diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index 9690695fce..93b9e695b7 100644
--- a/contrib/pg_upgrade/check.c
+++ b/contrib/pg_upgrade/check.c
@@ -532,7 +532,7 @@ check_for_prepared_transactions(ClusterInfo *cluster)
 
 	res = executeQueryOrDie(conn,
 							"SELECT * "
-							"FROM pg_catalog.pg_prepared_xact()");
+							"FROM pg_catalog.pg_prepared_xacts");
 
 	if (PQntuples(res) != 0)
 		pg_log(PG_FATAL, "The %s cluster contains prepared transactions\n",