From: Ted Kremenek <kremenek@apple.com>
Date: Wed, 13 Aug 2008 03:28:04 +0000 (+0000)
Subject: Initialize tracked local variables to undefined.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=72c59d07a3ef4f2c2798058244da40990e7ce8e4;p=clang

Initialize tracked local variables to undefined.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@54716 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/GRExprEngine.cpp b/lib/Analysis/GRExprEngine.cpp
index f0c0d8dd9e..a31c435786 100644
--- a/lib/Analysis/GRExprEngine.cpp
+++ b/lib/Analysis/GRExprEngine.cpp
@@ -202,10 +202,15 @@ const ValueState* GRExprEngine::getInitialState() {
     
     ScopedDecl *SD = const_cast<ScopedDecl*>(I->first);
     if (VarDecl* VD = dyn_cast<VarDecl>(SD)) {
-      if (VD->hasGlobalStorage() || isa<ParmVarDecl>(VD)) {
-        RVal X = RVal::GetSymbolValue(SymMgr, VD);
-        StateMgr.SetRVal(StateImpl, lval::DeclVal(VD), X);
-      }
+      // Initialize globals and parameters to symbolic values.
+      // Initialize local variables to undefined.
+      RVal X = (VD->hasGlobalStorage() || isa<ParmVarDecl>(VD) ||
+                isa<ImplicitParamDecl>(VD))
+             ? RVal::GetSymbolValue(SymMgr, VD)
+             : UndefinedVal();
+      
+      StateMgr.SetRVal(StateImpl, lval::DeclVal(VD), X);
+      
     } else if (ImplicitParamDecl *IPD = dyn_cast<ImplicitParamDecl>(SD)) {
         RVal X = RVal::GetSymbolValue(SymMgr, IPD);
       StateMgr.SetRVal(StateImpl, lval::DeclVal(IPD), X);
diff --git a/lib/Analysis/SymbolManager.cpp b/lib/Analysis/SymbolManager.cpp
index f243fa667b..beb4379f99 100644
--- a/lib/Analysis/SymbolManager.cpp
+++ b/lib/Analysis/SymbolManager.cpp
@@ -18,7 +18,8 @@ using namespace clang;
 
 SymbolID SymbolManager::getSymbol(VarDecl* D) {
 
-  assert (isa<ParmVarDecl>(D) || D->hasGlobalStorage());
+  assert (isa<ParmVarDecl>(D) || isa<ImplicitParamDecl>(D) || 
+          D->hasGlobalStorage());
   
   llvm::FoldingSetNodeID profile;