From: Richard Trieu <rtrieu@google.com>
Date: Sat, 17 Jan 2015 00:56:10 +0000 (+0000)
Subject: Clean up a string comparison with StringRef.  Suggestion by David Majnemer.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=715e549652ae8a92603c57888ef6835e292febe6;p=clang

Clean up a string comparison with StringRef.  Suggestion by David Majnemer.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@226359 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Basic/Diagnostic.cpp b/lib/Basic/Diagnostic.cpp
index 83228ad3c5..67504388b2 100644
--- a/lib/Basic/Diagnostic.cpp
+++ b/lib/Basic/Diagnostic.cpp
@@ -633,7 +633,8 @@ FormatDiagnostic(const char *DiagStr, const char *DiagEnd,
   // When the diagnostic string is only "%0", the entire string is being given
   // by an outside source.  Remove unprintable characters from this string
   // and skip all the other string processing.
-  if (DiagEnd - DiagStr == 2 && DiagStr[0] == '%' && DiagStr[1] == '0' &&
+  if (DiagEnd - DiagStr == 2 &&
+      StringRef(DiagStr, DiagEnd - DiagStr).equals("%0") &&
       getArgKind(0) == DiagnosticsEngine::ak_std_string) {
     const std::string &S = getArgStdStr(0);
     for (char c : S) {