From: Eric Liu Date: Wed, 18 Jul 2018 15:17:52 +0000 (+0000) Subject: [CodeComplete] Allow getDeclaration on RK_Pattern result. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=70cf0f619eaa16e62b228a20caee34af9be89ce8;p=clang [CodeComplete] Allow getDeclaration on RK_Pattern result. Summary: RK_Pattern results can also have associated declarations e.g. field decls in constructor initializers. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D49484 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@337394 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/Sema/CodeCompleteConsumer.h b/include/clang/Sema/CodeCompleteConsumer.h index 606f3b3690..ede3ddf919 100644 --- a/include/clang/Sema/CodeCompleteConsumer.h +++ b/include/clang/Sema/CodeCompleteConsumer.h @@ -895,9 +895,11 @@ public: computeCursorKindAndAvailability(); } - /// Retrieve the declaration stored in this result. + /// Retrieve the declaration stored in this result. This might be nullptr if + /// Kind is RK_Pattern. const NamedDecl *getDeclaration() const { - assert(Kind == RK_Declaration && "Not a declaration result"); + assert(((Kind == RK_Declaration) || (Kind == RK_Pattern)) && + "Not a declaration or pattern result"); return Declaration; }