From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 4 Nov 2008 15:16:48 +0000 (+0000)
Subject: Fix bug introduced in recent patch to make plpython cope with OUT arguments:
X-Git-Tag: REL8_4_BETA1~759
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=70b6e99e40c07c9dfaed932d466b8c4b687cbc15;p=postgresql

Fix bug introduced in recent patch to make plpython cope with OUT arguments:
the proc->argnames array has to be initialized to zero immediately on creation,
since the error recovery path will try to free its elements.
---

diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
index b732ac5427..1e136b22c6 100644
--- a/src/pl/plpython/plpython.c
+++ b/src/pl/plpython/plpython.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plpython.c - python as a procedural language for PostgreSQL
  *
- *	$PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.115 2008/11/02 01:45:28 tgl Exp $
+ *	$PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.116 2008/11/04 15:16:48 tgl Exp $
  *
  *********************************************************************
  */
@@ -1282,7 +1282,7 @@ PLy_procedure_create(HeapTuple procTup, Oid tgreloid, char *key)
 				}
 			}
 
-			proc->argnames = (char **) PLy_malloc(sizeof(char *) * proc->nargs);
+			proc->argnames = (char **) PLy_malloc0(sizeof(char *) * proc->nargs);
 			for (i = pos = 0; i < total; i++)
 			{
 				HeapTuple	argTypeTup;