From: Alexander Shaposhnikov <shal1t712@gmail.com>
Date: Tue, 15 Aug 2017 19:23:54 +0000 (+0000)
Subject: [clang] Code cleanup in clang/tooling
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=709ce01f5878ac12902d0b31d363ccd5a31fae74;p=clang

[clang] Code cleanup in clang/tooling

1. Add missing explicit for SymbolName constructor.
2. Add missing std::move in createRenameReplacements.

Differential revision: https://reviews.llvm.org/D36715


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@310948 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/clang/Tooling/Refactoring/Rename/SymbolName.h b/include/clang/Tooling/Refactoring/Rename/SymbolName.h
index 51db8b9a5d..e69d2908b5 100644
--- a/include/clang/Tooling/Refactoring/Rename/SymbolName.h
+++ b/include/clang/Tooling/Refactoring/Rename/SymbolName.h
@@ -29,7 +29,7 @@ namespace tooling {
 /// \endcode
 class SymbolName {
 public:
-  SymbolName(StringRef Name) {
+  explicit SymbolName(StringRef Name) {
     // While empty symbol names are valid (Objective-C selectors can have empty
     // name pieces), occurrences Objective-C selectors are created using an
     // array of strings instead of just one string.
diff --git a/lib/Tooling/Refactoring/Rename/RenamingAction.cpp b/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
index f4f4befc5d..9c000a7204 100644
--- a/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
+++ b/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
@@ -53,7 +53,7 @@ createRenameReplacements(const SymbolOccurrences &Occurrences,
     }
     Changes.push_back(std::move(Change));
   }
-  return Changes;
+  return std::move(Changes);
 }
 
 /// Takes each atomic change and inserts its replacements into the set of