From: Antony Dovgal <tony2001@php.net>
Date: Wed, 10 May 2006 10:06:57 +0000 (+0000)
Subject: fix #37392 (Unnecessary call to OCITransRollback() at the end of request)
X-Git-Tag: BEFORE_NEW_OUTPUT_API~251
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6fc10a0acd7d8c9cb91d0e0c9a6cdc3585504712;p=php

fix #37392 (Unnecessary call to OCITransRollback() at the end of request)
---

diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index 1c73008ed4..adb6fb298e 100644
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -1718,7 +1718,9 @@ static int php_oci_persistent_helper(zend_rsrc_list_entry *le TSRMLS_DC)
 				connection->descriptors = NULL;
 			}
 			
-			php_oci_connection_rollback(connection TSRMLS_CC);
+			if (connection->needs_commit) {
+				php_oci_connection_rollback(connection TSRMLS_CC);
+			}
 			
 			if (OCI_G(persistent_timeout) > 0) {
 				connection->idle_expiry = timestamp + OCI_G(persistent_timeout);