From: bert hubert <bert.hubert@powerdns.com>
Date: Sun, 7 Oct 2018 14:46:30 +0000 (+0200)
Subject: we shadowed the length variable on a successful cache hit that was
X-Git-Tag: rec-4.2.0-alpha1~42^2~15
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6f831900378d1388b35d14e20c4238344b39e06a;p=pdns

we shadowed the length variable on a successful cache hit that was
ECS-invariable
---

diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc
index 5fa255798..213ea51fe 100644
--- a/pdns/dnsdist.cc
+++ b/pdns/dnsdist.cc
@@ -1417,8 +1417,6 @@ static void processUDPQuery(ClientState& cs, LocalHolders& holders, const struct
         dnssecOK = (getEDNSZ(dq) & EDNS_HEADER_FLAG_DO);
       }
 
-      uint16_t cachedResponseSize = dq.size;
-      uint32_t allowExpired = ss ? 0 : g_staleCacheEntriesTTL;
       boost::optional<Netmask> subnet;
       if (packetCache && !dq.skipCache && packetCache->get(dq, consumed, dh->id, query, &cachedResponseSize, &cacheKeyNoECS, subnet, dnssecOK, allowExpired)) {
         goto sendIt;