From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 5 Jan 2018 09:12:20 +0000 (+0100)
Subject: perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}
X-Git-Tag: v2.17.0-rc0~145^2~6
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6f5ecad6a5566ac8dfb30c58330d53ef6cd5ad03;p=git

perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

The way we check ENV{GIT_PERF_SUBSECTION} could trigger
comparison between undef and "" that may be flagged by
use of strict & warnings. Let's fix that.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
index e401208488..769d418708 100755
--- a/t/perf/aggregate.perl
+++ b/t/perf/aggregate.perl
@@ -70,7 +70,7 @@ if (not @tests) {
 }
 
 my $resultsdir = "test-results";
-if ($ENV{GIT_PERF_SUBSECTION} ne "") {
+if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") {
 	$resultsdir .= "/" . $ENV{GIT_PERF_SUBSECTION};
 }