From: Marcus Boerger <helly@php.net>
Date: Fri, 30 May 2003 18:59:49 +0000 (+0000)
Subject: Use safe_estrdup() instead.
X-Git-Tag: RELEASE_1_0_2~507
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6f524ac9f1c3309819014be9228aac4666af6d5e;p=php

Use safe_estrdup() instead.
# Thanks Sascha i didn't knew about that thing.
---

diff --git a/ext/exif/exif.c b/ext/exif/exif.c
index c035f3685d..f568c8a822 100644
--- a/ext/exif/exif.c
+++ b/ext/exif/exif.c
@@ -3669,16 +3669,6 @@ static int exif_discard_imageinfo(image_info_type *ImageInfo)
 }
 /* }}} */
 
-/* {{{ estrdupx */
-static inline char * estrdupx(const char* str)
-{
-	if (str) {
-		return estrdup(str);
-	}
-	return estrdup("");
-}
-/* }}} */
-
 /* {{{ exif_read_file
  */
 static int exif_read_file(image_info_type *ImageInfo, char *FileName, int read_thumbnail, int read_all TSRMLS_DC)
@@ -3702,12 +3692,12 @@ static int exif_read_file(image_info_type *ImageInfo, char *FileName, int read_t
 	ImageInfo->read_all = read_all;
 	ImageInfo->Thumbnail.filetype = IMAGE_FILETYPE_UNKNOWN;
 
-	ImageInfo->encode_unicode    = estrdupx(EXIF_G(encode_unicode));
-	ImageInfo->decode_unicode_be = estrdupx(EXIF_G(decode_unicode_be));
-	ImageInfo->decode_unicode_le = estrdupx(EXIF_G(decode_unicode_le));
-	ImageInfo->encode_jis        = estrdupx(EXIF_G(encode_jis));
-	ImageInfo->decode_jis_be     = estrdupx(EXIF_G(decode_jis_be));
-	ImageInfo->decode_jis_le     = estrdupx(EXIF_G(decode_jis_le));
+	ImageInfo->encode_unicode    = safe_estrdup(EXIF_G(encode_unicode));
+	ImageInfo->decode_unicode_be = safe_estrdup(EXIF_G(decode_unicode_be));
+	ImageInfo->decode_unicode_le = safe_estrdup(EXIF_G(decode_unicode_le));
+	ImageInfo->encode_jis        = safe_estrdup(EXIF_G(encode_jis));
+	ImageInfo->decode_jis_be     = safe_estrdup(EXIF_G(decode_jis_be));
+	ImageInfo->decode_jis_le     = safe_estrdup(EXIF_G(decode_jis_le));
 
 	if (php_stream_is(ImageInfo->infile, PHP_STREAM_IS_STDIO)) {
 		if (VCWD_STAT(FileName, &st) >= 0) {