From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Tue, 31 Jul 2018 15:28:56 +0000 (-0700) Subject: [3.6] bpo-34263 Cap timeout submitted to epoll/select etc. to one day. (GH-8532)... X-Git-Tag: v3.6.7rc1~136 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6f16ffc1879fc934eba297b3e81bd940e32a7e03;p=python [3.6] bpo-34263 Cap timeout submitted to epoll/select etc. to one day. (GH-8532) (GH-8587) --- diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py index 79f0d63c57..30ac5924d0 100644 --- a/Lib/asyncio/base_events.py +++ b/Lib/asyncio/base_events.py @@ -56,6 +56,9 @@ _FATAL_ERROR_IGNORE = (BrokenPipeError, _HAS_IPv6 = hasattr(socket, 'AF_INET6') +# Maximum timeout passed to select to avoid OS limitations +MAXIMUM_SELECT_TIMEOUT = 24 * 3600 + def _format_handle(handle): cb = handle._callback @@ -1378,7 +1381,7 @@ class BaseEventLoop(events.AbstractEventLoop): elif self._scheduled: # Compute the desired timeout. when = self._scheduled[0]._when - timeout = max(0, when - self.time()) + timeout = min(max(0, when - self.time()), MAXIMUM_SELECT_TIMEOUT) if self._debug and timeout != 0: t0 = self.time() diff --git a/Misc/NEWS.d/next/Library/2018-07-28-17-00-36.bpo-34263.zUfRsu.rst b/Misc/NEWS.d/next/Library/2018-07-28-17-00-36.bpo-34263.zUfRsu.rst new file mode 100644 index 0000000000..799463b591 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2018-07-28-17-00-36.bpo-34263.zUfRsu.rst @@ -0,0 +1,2 @@ +asyncio's event loop will not pass timeouts longer than one day to +epoll/select etc.