From: Noah Misch <noah@leadboat.com>
Date: Thu, 4 Apr 2019 06:23:35 +0000 (-0700)
Subject: Silence -Wimplicit-fallthrough in sysv_shmem.c.
X-Git-Tag: REL_12_BETA1~311
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6f0e190056fe441f7cf788ff19b62b13c94f68f3;p=postgresql

Silence -Wimplicit-fallthrough in sysv_shmem.c.

Commit 2f932f71d9f2963bbd201129d7b971c8f5f077fd added code that elicits
a warning on buildfarm member flaviventris.  Back-patch to 9.4, like
that commit.

Reported by Andres Freund.

Discussion: https://postgr.es/m/20190404020057.galelv7by75ekqrh@alap3.anarazel.de
---

diff --git a/src/backend/port/sysv_shmem.c b/src/backend/port/sysv_shmem.c
index b5b7c7042d..df844ff9e3 100644
--- a/src/backend/port/sysv_shmem.c
+++ b/src/backend/port/sysv_shmem.c
@@ -672,6 +672,7 @@ PGSharedMemoryCreate(Size size, int port,
 								(unsigned long) shmid),
 						 errhint("Terminate any old server processes associated with data directory \"%s\".",
 								 DataDir)));
+				break;
 			case SHMSTATE_ENOENT:
 
 				/*
@@ -703,6 +704,7 @@ PGSharedMemoryCreate(Size size, int port,
 					dsm_cleanup_using_control_segment(oldhdr->dsm_control);
 				if (shmctl(shmid, IPC_RMID, NULL) < 0)
 					NextShmemSegID++;
+				break;
 		}
 
 		if (oldhdr && shmdt(oldhdr) < 0)