From: Fariborz Jahanian <fjahanian@apple.com>
Date: Mon, 7 Dec 2009 20:09:25 +0000 (+0000)
Subject: Allow accessing 'isa' via '->' operator.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6d910f07d8727c22e06cff2357bbc1bba25d0910;p=clang

Allow accessing 'isa' via '->' operator.
(fixes radar 7447251).


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@90795 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp
index 6c5a1ec05c..b3c5c9fc20 100644
--- a/lib/Sema/SemaExpr.cpp
+++ b/lib/Sema/SemaExpr.cpp
@@ -2522,6 +2522,16 @@ Sema::LookupMemberExpr(LookupResult &R, Expr *&BaseExpr,
   // If this is an Objective-C pseudo-builtin and a definition is provided then
   // use that.
   if (BaseType->isObjCIdType()) {
+    if (IsArrow) {
+      // Handle the following exceptional case PObj->isa.
+      if (const ObjCObjectPointerType *OPT =
+          BaseType->getAs<ObjCObjectPointerType>()) {
+        if (OPT->getPointeeType()->isSpecificBuiltinType(BuiltinType::ObjCId) &&
+            MemberName.getAsIdentifierInfo()->isStr("isa"))
+          return Owned(new (Context) ObjCIsaExpr(BaseExpr, false, MemberLoc,
+                                                 Context.getObjCIdType()));
+      }
+    }
     // We have an 'id' type. Rather than fall through, we check if this
     // is a reference to 'isa'.
     if (BaseType != Context.ObjCIdRedefinitionType) {
diff --git a/test/SemaObjC/id-isa-ref.m b/test/SemaObjC/id-isa-ref.m
index fa3293ce79..dbb6b2f53d 100644
--- a/test/SemaObjC/id-isa-ref.m
+++ b/test/SemaObjC/id-isa-ref.m
@@ -1,8 +1,5 @@
 // RUN: clang-cc -fsyntax-only -verify %s
 
-// Failing currently due to Obj-C type representation changes. 2009-09-17
-// XFAIL: *
-
 typedef struct objc_object {
   struct objc_class *isa;
 } *id;