From: Antoine Pitrou <solipsis@pitrou.net>
Date: Sun, 20 Mar 2011 22:56:36 +0000 (+0100)
Subject: Issue #11127: Raise a TypeError when trying to pickle a socket object.
X-Git-Tag: v3.3.0a1~2828
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6d58d64919bb12e05fa4bf3a34909650c695cff6;p=python

Issue #11127: Raise a TypeError when trying to pickle a socket object.
---

diff --git a/Lib/socket.py b/Lib/socket.py
index 1e285493c4..57150349a5 100644
--- a/Lib/socket.py
+++ b/Lib/socket.py
@@ -112,6 +112,9 @@ class socket(_socket.socket):
                                 s[7:])
         return s
 
+    def __getstate__(self):
+        raise TypeError("Cannot serialize socket object")
+
     def dup(self):
         """dup() -> socket object
 
diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
index d761a73f2f..8b23ae9924 100644
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -18,6 +18,7 @@ import contextlib
 from weakref import proxy
 import signal
 import math
+import pickle
 try:
     import fcntl
 except ImportError:
@@ -764,6 +765,12 @@ class GeneralModuleTests(unittest.TestCase):
             fp.close()
             self.assertEqual(repr(fp), "<_io.BufferedReader name=-1>")
 
+    def test_pickle(self):
+        sock = socket.socket()
+        with sock:
+            for protocol in range(pickle.HIGHEST_PROTOCOL + 1):
+                self.assertRaises(TypeError, pickle.dumps, sock, protocol)
+
 
 @unittest.skipUnless(thread, 'Threading required for this test.')
 class BasicTCPTest(SocketConnectedTest):
diff --git a/Misc/NEWS b/Misc/NEWS
index d55c88869f..b2e7a56bf7 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -83,6 +83,8 @@ Library
 
 - Issue #4391: Use proper gettext plural forms in optparse.
 
+- Issue #11127: Raise a TypeError when trying to pickle a socket object.
+
 - Issue #11563: Connection:close header is sent by requests using URLOpener
   class which helps in closing of sockets after connection is over. Patch
   contributions by Jeff McNeil and Nadeem Vawda.