From: Georg Brandl <georg@python.org>
Date: Mon, 26 Feb 2007 13:48:28 +0000 (+0000)
Subject: Fix a refleak in PyString_Format.
X-Git-Tag: v3.0a1~1177
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6ce7d1ed55b579c03334d8ef7a69102484d02ff1;p=python

Fix a refleak in PyString_Format.
---

diff --git a/Objects/stringobject.c b/Objects/stringobject.c
index d772e74c07..7212df904e 100644
--- a/Objects/stringobject.c
+++ b/Objects/stringobject.c
@@ -4780,10 +4780,13 @@ PyString_Format(PyObject *format, PyObject *args)
 				reslen += rescnt;
 				if (reslen < 0) {
 					Py_DECREF(result);
+					Py_XDECREF(temp);
 					return PyErr_NoMemory();
 				}
-				if (_PyString_Resize(&result, reslen) < 0)
+				if (_PyString_Resize(&result, reslen) < 0) {
+					Py_XDECREF(temp);
 					return NULL;
+				}
 				res = PyString_AS_STRING(result)
 					+ reslen - rescnt;
 			}
@@ -4834,6 +4837,7 @@ PyString_Format(PyObject *format, PyObject *args)
                         if (dict && (argidx < arglen) && c != '%') {
                                 PyErr_SetString(PyExc_TypeError,
                                            "not all arguments converted during string formatting");
+                                Py_XDECREF(temp);
                                 goto error;
                         }
 			Py_XDECREF(temp);