From: Greg Ames <gregames@apache.org>
Date: Mon, 4 Feb 2002 21:19:08 +0000 (+0000)
Subject: vetoing and backing out OtherBill's patch rev 1.91.  This breaks
X-Git-Tag: 2.0.32~92
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6cbb3ef98ea7ccb6651e58ea9a7f9d4d8c4e42b7;p=apache

vetoing and backing out OtherBill's patch rev 1.91.  This breaks
mod_autoindex on systems such as Unix where apr_dir_read doesn't automatically
return the filetype.  You see a '?' icon rather than a folder icon
for directories on 2.0.31 because mod_autoindex doesn't realize that the thing
is a directory.

No, we don't want more stat()s either.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93232 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/generators/mod_autoindex.c b/modules/generators/mod_autoindex.c
index bef602ae24..aad5199b2b 100644
--- a/modules/generators/mod_autoindex.c
+++ b/modules/generators/mod_autoindex.c
@@ -1298,7 +1298,7 @@ static struct ent *make_autoindex_entry(const apr_finfo_t *dirent,
     }
 
     p = (struct ent *) apr_pcalloc(r->pool, sizeof(struct ent));
-    if (dirent->filetype == APR_DIR) {
+    if (rr->finfo.filetype == APR_DIR) {
         p->name = apr_pstrcat(r->pool, dirent->name, "/", NULL);
     }
     else {
@@ -1316,7 +1316,7 @@ static struct ent *make_autoindex_entry(const apr_finfo_t *dirent,
 
     if (autoindex_opts & (FANCY_INDEXING | TABLE_INDEXING)) {
         p->lm = rr->finfo.mtime;
-        if (dirent->filetype == APR_DIR) {
+        if (rr->finfo.filetype == APR_DIR) {
             if (autoindex_opts & FOLDERS_FIRST) {
                 p->isdir = 1;
             }