From: George Peter Banyard <girgias@php.net>
Date: Wed, 28 Aug 2019 21:57:51 +0000 (+0200)
Subject: Promote warnings to errors in assert_options()
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6c0eb1be333848d62272e195dc814da1432ce793;p=php

Promote warnings to errors in assert_options()
---

diff --git a/ext/standard/assert.c b/ext/standard/assert.c
index ffd3363861..b5b8e910be 100644
--- a/ext/standard/assert.c
+++ b/ext/standard/assert.c
@@ -316,10 +316,10 @@ PHP_FUNCTION(assert_options)
 		break;
 
 	default:
-		php_error_docref(NULL, E_WARNING, "Unknown value " ZEND_LONG_FMT, what);
+		zend_throw_error(NULL, "Unknown value " ZEND_LONG_FMT, what);
 		break;
 	}
 
-	RETURN_FALSE;
+	return;
 }
 /* }}} */
diff --git a/ext/standard/tests/assert/assert_options_error.phpt b/ext/standard/tests/assert/assert_options_error.phpt
new file mode 100644
index 0000000000..0b50370b6c
--- /dev/null
+++ b/ext/standard/tests/assert/assert_options_error.phpt
@@ -0,0 +1,13 @@
+--TEST--
+assert_options() - unknown assert option.
+
+--FILE--
+<?php
+try {
+    assert_options(1000);
+} catch (\Error $e) {
+    echo $e->getMessage();
+}
+?>
+--EXPECT--
+Unknown value 1000
\ No newline at end of file