From: Matthew Ahrens Date: Thu, 2 May 2019 00:32:54 +0000 (-0700) Subject: Remove incorrect (and inappropriate) comment in dprintf_dnode X-Git-Tag: zfs-0.8.0-rc5~24 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6bdefad311a87452b557febd5be33b627775a006;p=zfs Remove incorrect (and inappropriate) comment in dprintf_dnode This comment seems to misunderstand the ## preprocessor token, which does token concatenation. It is not needed here, since we are concatenating string literals, which is performed by putting the literals next to each other. Additionally, the comment uses offensive language. Reviewed-by: Igor Kozhukhov Reviewed-by: Brian Behlendorf Reviewed-by: George Melikov Reviewed-by: Tony Nguyen Signed-off-by: Matthew Ahrens Closes #8698 Closes #8699 --- diff --git a/include/sys/dnode.h b/include/sys/dnode.h index 6355aaa50..accbe6945 100644 --- a/include/sys/dnode.h +++ b/include/sys/dnode.h @@ -589,11 +589,6 @@ extern dnode_stats_t dnode_stats; #ifdef ZFS_DEBUG -/* - * There should be a ## between the string literal and fmt, to make it - * clear that we're joining two strings together, but that piece of shit - * gcc doesn't support that preprocessor token. - */ #define dprintf_dnode(dn, fmt, ...) do { \ if (zfs_flags & ZFS_DEBUG_DPRINTF) { \ char __db_buf[32]; \