From: Terry Jan Reedy Date: Tue, 17 May 2016 02:27:28 +0000 (-0400) Subject: Issue #27044: stop test_idle from leaking by deleting callbacks. X-Git-Tag: v3.5.2rc1~154 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6b98ce23f686b5533ab4bcddfe2c9136565e4919;p=python Issue #27044: stop test_idle from leaking by deleting callbacks. --- diff --git a/Lib/idlelib/configDialog.py b/Lib/idlelib/configDialog.py index f00db39d8f..b7022537e6 100644 --- a/Lib/idlelib/configDialog.py +++ b/Lib/idlelib/configDialog.py @@ -483,6 +483,17 @@ class ConfigDialog(Toplevel): self.autoSave.trace_variable('w', self.VarChanged_autoSave) self.encoding.trace_variable('w', self.VarChanged_encoding) + def remove_var_callbacks(self): + "Remove callbacks to prevent memory leaks." + for var in ( + self.fontSize, self.fontName, self.fontBold, + self.spaceNum, self.colour, self.builtinTheme, + self.customTheme, self.themeIsBuiltin, self.highlightTarget, + self.keyBinding, self.builtinKeys, self.customKeys, + self.keysAreBuiltin, self.winWidth, self.winHeight, + self.startupEdit, self.autoSave, self.encoding,): + var.trace_vdelete('w', var.trace_vinfo()[0][1]) + def VarChanged_font(self, *params): '''When one font attribute changes, save them all, as they are not independent from each other. In particular, when we are diff --git a/Lib/idlelib/idle_test/test_configdialog.py b/Lib/idlelib/idle_test/test_configdialog.py index 68831236b7..fab860b439 100644 --- a/Lib/idlelib/idle_test/test_configdialog.py +++ b/Lib/idlelib/idle_test/test_configdialog.py @@ -25,6 +25,7 @@ class ConfigDialogTest(unittest.TestCase): def test_dialog(self): d=ConfigDialog(self.root, 'Test', _utest=True) + d.remove_var_callbacks() d.destroy()