From: Georg Brandl <georg@python.org>
Date: Fri, 3 Jun 2005 19:47:00 +0000 (+0000)
Subject: Bug #1194181: bz2.BZ2File didn't handle mode 'U' correctly.
X-Git-Tag: v2.5a0~1747
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6b95f1d963d3fd2dcc2e84e83b514364e9f52006;p=python

Bug #1194181: bz2.BZ2File didn't handle mode 'U' correctly.
---

diff --git a/Lib/test/test_bz2.py b/Lib/test/test_bz2.py
index 7d844d8e83..fc8213f55a 100644
--- a/Lib/test/test_bz2.py
+++ b/Lib/test/test_bz2.py
@@ -235,6 +235,16 @@ class BZ2FileTest(BaseTest):
         # "Test opening a nonexistent file"
         self.assertRaises(IOError, BZ2File, "/non/existent")
 
+    def testModeU(self):
+        # Bug #1194181: bz2.BZ2File opened for write with mode "U"
+        self.createTempFile()
+        bz2f = BZ2File(self.filename, "U")
+        bz2f.close()
+        f = file(self.filename)
+        f.seek(0, 2)
+        self.assertEqual(f.tell(), len(self.DATA))
+        f.close()
+
 class BZ2CompressorTest(BaseTest):
     def testCompress(self):
         # "Test BZ2Compressor.compress()/flush()"
diff --git a/Misc/NEWS b/Misc/NEWS
index 67ccb42637..637ca2eb13 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -91,6 +91,8 @@ Core and builtins
 Extension Modules
 -----------------
 
+- Bug #1194181: bz2.BZ2File didn't handle mode 'U' correctly.
+
 - Patch #1212117: os.stat().st_flags is now accessible as a attribute
   if available on the platform.
 
diff --git a/Modules/bz2module.c b/Modules/bz2module.c
index 8a93cd9547..b9874eb07e 100644
--- a/Modules/bz2module.c
+++ b/Modules/bz2module.c
@@ -1308,6 +1308,10 @@ BZ2File_init(BZ2FileObject *self, PyObject *args, PyObject *kwargs)
 			break;
 	}
 
+	if (mode_char == 0) {
+		mode_char = 'r';
+	}
+
 	mode = (mode_char == 'r') ? "rb" : "wb";
 
 	self->file = PyObject_CallFunction((PyObject*)&PyFile_Type, "(Osi)",