From: Stefan Esser <sesser@php.net>
Date: Thu, 8 Apr 2004 14:58:04 +0000 (+0000)
Subject: Fixed: possible remote overflow and possible efree(NULL) crash
X-Git-Tag: php-5.0.0RC2RC1~48
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6b12a45247094c40c11db6d76f1a4c7361202228;p=php

Fixed: possible remote overflow and possible efree(NULL) crash
---

diff --git a/ext/soap/php_http.c b/ext/soap/php_http.c
index 6072c3245a..d41874b9ed 100644
--- a/ext/soap/php_http.c
+++ b/ext/soap/php_http.c
@@ -869,6 +869,10 @@ static int get_http_body(php_stream *stream, char *headers,  char **response, in
 				if (buf_size > 0) {
 					int len_size = 0;
 
+					if (http_buf_size + buf_size + 1 < 0) {
+						efree(http_buf);
+						return FALSE;
+					}
 					http_buf = erealloc(http_buf, http_buf_size + buf_size + 1);
 
 					while (len_size < buf_size) {
@@ -888,7 +892,9 @@ static int get_http_body(php_stream *stream, char *headers,  char **response, in
 				php_stream_getc(stream);
 			} else {
 				/* Somthing wrong in chunked encoding */
-				efree(http_buf);
+				if (http_buf) {
+					efree(http_buf);
+				}
 				return FALSE;
 			}
 			if (buf_size == 0) {
@@ -901,14 +907,25 @@ static int get_http_body(php_stream *stream, char *headers,  char **response, in
 		}
 
 	} else if (header_length) {
+		if (header_length < 0) {
+			return FALSE;
+		}
 		http_buf = emalloc(header_length + 1);
 		while (http_buf_size < header_length) {
-			http_buf_size += php_stream_read(stream, http_buf + http_buf_size, header_length - http_buf_size);
+			int len_read = php_stream_read(stream, http_buf + http_buf_size, header_length - http_buf_size);
+			if (len_read <= 0) {
+				break;
+			}
+			http_buf_size += len_read;
 		}
 	} else if (header_close) {
 		do {
+			int len_read;
 			http_buf = erealloc(http_buf, http_buf_size + 4096 + 1);
-			http_buf_size += php_stream_read(stream, http_buf + http_buf_size, 4096);
+			len_read = php_stream_read(stream, http_buf + http_buf_size, 4096);
+			if (len_read > 0) {
+				http_buf_size += len_read;
+			}
 		} while(!php_stream_eof(stream));
 	} else {
 		return FALSE;