From: zeertzjq <zeertzjq@outlook.com>
Date: Wed, 23 Feb 2022 12:23:08 +0000 (+0000)
Subject: patch 8.2.4454: resetting cmdwin_type only for one situation
X-Git-Tag: v8.2.4454
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6a8b13614e5bcb233d20403ae9f008ccba152be3;p=vim

patch 8.2.4454: resetting cmdwin_type only for one situation

Problem:    Resetting cmdwin_type only for one situation.
Solution:   Reset cmdwin_type before closing windows. (closes #9822)
---

diff --git a/src/testdir/test_exit.vim b/src/testdir/test_exit.vim
index 7e50e78ba..c05374cb8 100644
--- a/src/testdir/test_exit.vim
+++ b/src/testdir/test_exit.vim
@@ -119,6 +119,7 @@ func Test_exit_error_reading_input()
   call writefile([":au VimLeave * call writefile(['l = ' .. v:exiting], 'Xtestout')", ":tabnew", "q:"], 'Xscript', 'b')
 
   if RunVim([], [], '<Xscript')
+    call assert_equal(1, v:shell_error)
     call assert_equal(['l = 1'], readfile('Xtestout'))
   endif
   call delete('Xscript')
diff --git a/src/ui.c b/src/ui.c
index bf6ea858b..a6cee804a 100644
--- a/src/ui.c
+++ b/src/ui.c
@@ -1065,9 +1065,6 @@ read_error_exit(void)
     if (silent_mode)	// Normal way to exit for "ex -s"
 	getout(0);
     STRCPY(IObuff, _("Vim: Error reading input, exiting...\n"));
-#ifdef FEAT_CMDWIN
-    cmdwin_type = 0;
-#endif
     preserve_exit();
 }
 
diff --git a/src/version.c b/src/version.c
index 57f32cbe4..5da1833d2 100644
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    4454,
 /**/
     4453,
 /**/
diff --git a/src/window.c b/src/window.c
index 7da7b89e8..ceb7d5958 100644
--- a/src/window.c
+++ b/src/window.c
@@ -2856,6 +2856,10 @@ win_free_all(void)
 {
     int		dummy;
 
+#ifdef FEAT_CMDWIN
+    // avoid an error for switching tabpage with the cmdline window open
+    cmdwin_type = 0;
+#endif
     while (first_tabpage->tp_next != NULL)
 	tabpage_close(TRUE);