From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Fri, 13 May 2022 15:04:07 +0000 (-0700)
Subject: mingle: remove unused 'total_wgt' in 'agglomerative_ink_bundling_internal'
X-Git-Tag: 4.0.0~40^2~3
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6a7ec065ddc8155f6d1f165b626c76b382d918ae;p=graphviz

mingle: remove unused 'total_wgt' in 'agglomerative_ink_bundling_internal'

The CMake macOS CI job has begun erroring out:

  …/lib/mingle/agglomerative_bundling.cpp:400:27: error: variable 'total_wgt'
    set but not used [-Werror,-Wunused-but-set-variable]
  double eps = 0., wgt, total_wgt = 0;
                        ^

While the error is accurate, nothing has changed on our side that would have
caused this. I can only assume Gitlab have upgraded the macOS runners to pull in
a new version of Clang.
---

diff --git a/lib/mingle/agglomerative_bundling.cpp b/lib/mingle/agglomerative_bundling.cpp
index 0d285dfaa..213bb118a 100644
--- a/lib/mingle/agglomerative_bundling.cpp
+++ b/lib/mingle/agglomerative_bundling.cpp
@@ -397,7 +397,7 @@ static pedge* agglomerative_ink_bundling_internal(int dim, SparseMatrix A, pedge
     pedge *mid_edges, midedge;/* middle section of edges that will be bundled again */
     int ne, npp, l;
     SparseMatrix A_mid;
-    double eps = 0., wgt, total_wgt = 0;
+    double eps = 0., wgt;
 
    /* make new edges using meet1 and meet2.
        
@@ -417,7 +417,6 @@ static pedge* agglomerative_ink_bundling_internal(int dim, SparseMatrix A, pedge
       pick = &(ja[ia[i]]);
       wgt = 0.;
       for (j = ia[i]; j < ia[i+1]; j++) wgt += edges[j]->wgt;
-      total_wgt += wgt;
       if (DEBUG) if (Verbose) fprintf(stderr,"calling ink3...\n");
       ink1 = ink(edges, ia[i+1]-ia[i], pick, &ink0, &meet1, &meet2, angle_param, angle);
       if (DEBUG) if (Verbose) fprintf(stderr,"done calling ink3...\n");