From: Richard Russon <rich@flatcap.org>
Date: Mon, 4 Dec 2017 23:46:04 +0000 (+0000)
Subject: return early where possible
X-Git-Tag: neomutt-20171208~8^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6a7a8375c9557ddb6455d2f3a79bada1ff40f0fb;p=neomutt

return early where possible
---

diff --git a/init.c b/init.c
index 7d9580376..e0d0cde10 100644
--- a/init.c
+++ b/init.c
@@ -1150,11 +1150,11 @@ static int parse_unstailq(struct Buffer *buf, struct Buffer *s,
 
 static void alternates_clean(void)
 {
-  if (Context && Context->msgcount)
-  {
-    for (int i = 0; i < Context->msgcount; i++)
-      Context->hdrs[i]->recip_valid = false;
-  }
+  if (!Context)
+    return;
+
+  for (int i = 0; i < Context->msgcount; i++)
+    Context->hdrs[i]->recip_valid = false;
 }
 
 static int parse_alternates(struct Buffer *buf, struct Buffer *s,
@@ -1269,11 +1269,11 @@ static int parse_unreplace_list(struct Buffer *buf, struct Buffer *s,
 
 static void clear_subject_mods(void)
 {
-  if (Context && Context->msgcount)
-  {
-    for (int i = 0; i < Context->msgcount; i++)
-      FREE(&Context->hdrs[i]->env->disp_subj);
-  }
+  if (!Context)
+    return;
+
+  for (int i = 0; i < Context->msgcount; i++)
+    FREE(&Context->hdrs[i]->env->disp_subj);
 }
 
 static int parse_subjectrx_list(struct Buffer *buf, struct Buffer *s,
@@ -1537,11 +1537,11 @@ bail:
  */
 static void attachments_clean(void)
 {
-  if (Context && Context->msgcount)
-  {
-    for (int i = 0; i < Context->msgcount; i++)
-      Context->hdrs[i]->attach_valid = false;
-  }
+  if (!Context)
+    return;
+
+  for (int i = 0; i < Context->msgcount; i++)
+    Context->hdrs[i]->attach_valid = false;
 }
 
 static int parse_attach_list(struct Buffer *buf, struct Buffer *s,