From: Bruce Momjian <bruce@momjian.us>
Date: Sat, 8 Jan 2000 22:58:03 +0000 (+0000)
Subject: This patch removes the initialization of ri in loop in
X-Git-Tag: REL7_0~926
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=69d4299e3e534686274480ba245566914932c017;p=postgresql

This patch removes the initialization of ri in loop in
quote_postgres(...) in ecpglib.c.

The code in CVS reads:

quote_postgres(char *arg, int lineno)
{
 char    *res = (char *) ecpg_alloc(2 * strlen(arg) + 3, lineno);
 int   i,
    ri = 0;

 if (!res)
  return (res);

 res[ri++] = '\'';
 for (i = 0, ri=0; arg[i]; i++, ri++)
 {
  switch (arg[i])
  {
   case '\'':
    res[ri++] = '\'';
    break;
   case '\\':
    res[ri++] = '\\';
    break;
   default:
    ;
  }

The problem here is that ri is reset to 0, thus overwriting the initial
quote.

Stephen Birch
---

diff --git a/src/interfaces/ecpg/lib/ecpglib.c b/src/interfaces/ecpg/lib/ecpglib.c
index 4c0134c393..5190dd0635 100644
--- a/src/interfaces/ecpg/lib/ecpglib.c
+++ b/src/interfaces/ecpg/lib/ecpglib.c
@@ -238,7 +238,7 @@ quote_postgres(char *arg, int lineno)
 		return (res);
 
 	res[ri++] = '\'';
-	for (i = 0, ri = 0; arg[i]; i++, ri++)
+	for (i = 0; arg[i]; i++, ri++)
 	{
 		switch (arg[i])
 		{