From: Guido van Rossum <guido@python.org>
Date: Wed, 9 Apr 2003 19:31:02 +0000 (+0000)
Subject: Fix two crashes on Windows:
X-Git-Tag: v2.3c1~1241
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=69c2b883922a758ed84de2cf94b5485d7e078fd3;p=python

Fix two crashes on Windows:
- CHECK_VALID() was checking the wrong value for a closed fd
- fseek(&_iob[fileno], ...) doesn't work for fileno >= 20
---

diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index fcec0de391..c2c723c302 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -154,7 +154,7 @@ mmap_close_method(mmap_object *self, PyObject *args)
 #ifdef MS_WINDOWS
 #define CHECK_VALID(err)						\
 do {									\
-    if (!self->map_handle) {						\
+    if (self->map_handle == INVALID_HANDLE_VALUE) {						\
 	PyErr_SetString (PyExc_ValueError, "mmap closed or invalid");	\
 	return err;							\
     }									\
@@ -974,7 +974,7 @@ new_mmap_object(PyObject *self, PyObject *args, PyObject *kwdict)
 			return NULL;
 		}
 		/* Win9x appears to need us seeked to zero */
-		fseek(&_iob[fileno], 0, SEEK_SET);
+		lseek(fileno, 0, SEEK_SET);
 	}
 
 	m_obj = PyObject_New (mmap_object, &mmap_object_type);