From: Tim Peters <tim.peters@gmail.com>
Date: Fri, 30 Nov 2001 07:23:05 +0000 (+0000)
Subject: unicodedata_decomposition():  sprintf -> PyOS_snprintf.
X-Git-Tag: v2.2.1c1~640
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=69b83b113f9e6fed321288ea23bca2aa673a7beb;p=python

unicodedata_decomposition():  sprintf -> PyOS_snprintf.
---

diff --git a/Modules/unicodedata.c b/Modules/unicodedata.c
index 4711123eb2..36c96e4a63 100644
--- a/Modules/unicodedata.c
+++ b/Modules/unicodedata.c
@@ -227,7 +227,7 @@ unicodedata_decomposition(PyObject *self, PyObject *args)
                              (code&((1<<DECOMP_SHIFT)-1))];
     }
 
-    /* high byte is of hex bytes (usually one or two), low byte
+    /* high byte is number of hex bytes (usually one or two), low byte
        is prefix code (from*/
     count = decomp_data[index] >> 8;
 
@@ -241,7 +241,9 @@ unicodedata_decomposition(PyObject *self, PyObject *args)
     while (count-- > 0) {
         if (i)
             decomp[i++] = ' ';
-        sprintf(decomp + i, "%04X", decomp_data[++index]);
+        assert((size_t)i < sizeof(decomp));
+        PyOS_snprintf(decomp + i, sizeof(decomp) - i, "%04X",
+                      decomp_data[++index]);
         i += strlen(decomp + i);
     }