From: George Peter Banyard <girgias@php.net>
Date: Thu, 26 Mar 2020 02:20:10 +0000 (+0100)
Subject: Explicitly declare the char as signed in zend_ffi_val.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=69b7d011d8cae9b52cf0481037cbec46a8c500ac;p=php

Explicitly declare the char as signed in zend_ffi_val.

This causes issues down the line as char are unsigned on some platforms,
e.g. ARM and cause a [-Wtype-limits] warning to be emitted.
---

diff --git a/ext/ffi/php_ffi.h b/ext/ffi/php_ffi.h
index fc6120de79..3a10b45478 100644
--- a/ext/ffi/php_ffi.h
+++ b/ext/ffi/php_ffi.h
@@ -198,7 +198,7 @@ typedef struct _zend_ffi_val {
 		uint64_t        u64;
 		int64_t         i64;
 		zend_ffi_double d;
-		char            ch;
+		signed char     ch;
 		struct {
 			const char *str;
 			size_t      len;