From: Fariborz Jahanian Date: Sat, 4 Sep 2010 19:49:18 +0000 (+0000) Subject: Casting of a property reference to 'void' did not X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=699c06068dab18efd37897659ec120d211827607;p=clang Casting of a property reference to 'void' did not generate the necessary code. This patch fixes it. // rdar://8389655 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@113079 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/CGExprScalar.cpp b/lib/CodeGen/CGExprScalar.cpp index 2318cc4e9a..eb4929d138 100644 --- a/lib/CodeGen/CGExprScalar.cpp +++ b/lib/CodeGen/CGExprScalar.cpp @@ -1038,8 +1038,13 @@ Value *ScalarExprEmitter::EmitCastExpr(CastExpr *CE) { return Builder.CreatePtrToInt(Src, ConvertType(DestTy)); } case CK_ToVoid: { - if (E->Classify(CGF.getContext()).isGLValue()) - CGF.EmitLValue(E); + if (E->Classify(CGF.getContext()).isGLValue()) { + LValue LV = CGF.EmitLValue(E); + if (LV.isPropertyRef()) + CGF.EmitLoadOfPropertyRefLValue(LV, E->getType()); + else if (LV.isKVCRef()) + CGF.EmitLoadOfKVCRefLValue(LV, E->getType()); + } else CGF.EmitAnyExpr(E, 0, false, true); return 0; diff --git a/test/CodeGenObjC/property-ref-cast-to-void.m b/test/CodeGenObjC/property-ref-cast-to-void.m new file mode 100644 index 0000000000..a365aa56e8 --- /dev/null +++ b/test/CodeGenObjC/property-ref-cast-to-void.m @@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -x objective-c++ -triple x86_64-apple-darwin9 -emit-llvm -o - %s | FileCheck %s + +// rdar: // 8399655 +@interface TestClass +@property (readonly) int myProperty; +- (int)myProperty; +- (double)myGetter; +@end + +void FUNC () { + TestClass *obj; + (void)obj.myProperty; + (void)obj.myGetter; +} + +// CHECK: call i32 bitcast +// CHECK: call double bitcast