From: Felipe Pena Date: Sun, 14 Nov 2010 18:40:08 +0000 (+0000) Subject: - Added missing void arg checks X-Git-Tag: php-5.3.4RC1~32 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6958cb4a1441c59d054b1a3a65f6dfc9ea7a58f9;p=php - Added missing void arg checks --- diff --git a/ext/spl/php_spl.c b/ext/spl/php_spl.c index 69b07162af..8b6a44ccaa 100755 --- a/ext/spl/php_spl.c +++ b/ext/spl/php_spl.c @@ -339,14 +339,13 @@ PHP_FUNCTION(spl_autoload) Register and return default file extensions for spl_autoload */ PHP_FUNCTION(spl_autoload_extensions) { - char *file_exts; + char *file_exts = NULL; int file_exts_len; - if (ZEND_NUM_ARGS() > 0) { - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &file_exts, &file_exts_len) == FAILURE) { - return; - } - + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|s", &file_exts, &file_exts_len) == FAILURE) { + return; + } + if (file_exts) { if (SPL_G(autoload_extensions)) { efree(SPL_G(autoload_extensions)); } @@ -669,6 +668,10 @@ PHP_FUNCTION(spl_autoload_functions) HashPosition function_pos; autoload_func_info *alfi; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + if (!EG(autoload_func)) { if (zend_hash_find(EG(function_table), ZEND_AUTOLOAD_FUNC_NAME, sizeof(ZEND_AUTOLOAD_FUNC_NAME), (void **) &fptr) == SUCCESS) { array_init(return_value); diff --git a/ext/spl/spl_array.c b/ext/spl/spl_array.c index c7858dda08..d355546cf1 100755 --- a/ext/spl/spl_array.c +++ b/ext/spl/spl_array.c @@ -1143,6 +1143,10 @@ SPL_METHOD(Array, getIteratorClass) { zval *object = getThis(); spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_STRING(intern->ce_get_iterator->name, 1); } @@ -1155,6 +1159,10 @@ SPL_METHOD(Array, getFlags) zval *object = getThis(); spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(intern->ar_flags & ~SPL_ARRAY_INT_MASK); } /* }}} */ @@ -1202,6 +1210,10 @@ SPL_METHOD(Array, getIterator) spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); spl_array_object *iterator; HashTable *aht = spl_array_get_hash_table(intern, 0 TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!aht) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); @@ -1221,6 +1233,10 @@ SPL_METHOD(Array, rewind) { zval *object = getThis(); spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_array_rewind(intern TSRMLS_CC); } @@ -1316,6 +1332,10 @@ SPL_METHOD(Array, count) { long count; spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_array_object_count_elements_helper(intern, &count TSRMLS_CC); @@ -1399,6 +1419,10 @@ SPL_METHOD(Array, current) spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); zval **entry; HashTable *aht = spl_array_get_hash_table(intern, 0 TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!aht) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); @@ -1421,6 +1445,10 @@ SPL_METHOD(Array, current) Return current array key */ SPL_METHOD(Array, key) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } + spl_array_iterator_key(getThis(), return_value TSRMLS_CC); } /* }}} */ @@ -1463,6 +1491,10 @@ SPL_METHOD(Array, next) spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); HashTable *aht = spl_array_get_hash_table(intern, 0 TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + if (!aht) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); return; @@ -1480,6 +1512,10 @@ SPL_METHOD(Array, valid) spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); HashTable *aht = spl_array_get_hash_table(intern, 0 TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + if (!aht) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); return; @@ -1502,6 +1538,10 @@ SPL_METHOD(Array, hasChildren) spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); HashTable *aht = spl_array_get_hash_table(intern, 0 TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + if (!aht) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); RETURN_FALSE; @@ -1527,6 +1567,10 @@ SPL_METHOD(Array, getChildren) zval *object = getThis(), **entry, *flags; spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); HashTable *aht = spl_array_get_hash_table(intern, 0 TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!aht) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); @@ -1563,7 +1607,7 @@ smart_str spl_array_serialize_helper(spl_array_object *intern, php_serialize_dat zval members, *pmembers; smart_str buf = {0}; zval *flags; - + if (!aht) { php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); return buf; @@ -1603,6 +1647,10 @@ SPL_METHOD(Array, serialize) spl_array_object *intern = (spl_array_object*)zend_object_store_get_object(object TSRMLS_CC); int was_in_serialize = intern->serialize_data != NULL; smart_str buf; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!was_in_serialize) { intern->serialize_data = emalloc(sizeof(php_serialize_data_t)); diff --git a/ext/spl/spl_directory.c b/ext/spl/spl_directory.c index f4c61fd5c1..797ed6dbeb 100755 --- a/ext/spl/spl_directory.c +++ b/ext/spl/spl_directory.c @@ -674,6 +674,10 @@ SPL_METHOD(DirectoryIterator, __construct) SPL_METHOD(DirectoryIterator, rewind) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern->u.dir.index = 0; if (intern->u.dir.dirp) { @@ -688,6 +692,10 @@ SPL_METHOD(DirectoryIterator, rewind) SPL_METHOD(DirectoryIterator, key) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (intern->u.dir.dirp) { RETURN_LONG(intern->u.dir.index); @@ -701,6 +709,9 @@ SPL_METHOD(DirectoryIterator, key) Return this (needed for Iterator interface) */ SPL_METHOD(DirectoryIterator, current) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_ZVAL(getThis(), 1, 0); } /* }}} */ @@ -711,6 +722,10 @@ SPL_METHOD(DirectoryIterator, next) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); int skip_dots = SPL_HAS_FLAG(intern->flags, SPL_FILE_DIR_SKIPDOTS); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern->u.dir.index++; do { @@ -765,6 +780,10 @@ SPL_METHOD(DirectoryIterator, seek) SPL_METHOD(DirectoryIterator, valid) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_BOOL(intern->u.dir.entry.d_name[0] != '\0'); } @@ -777,6 +796,10 @@ SPL_METHOD(SplFileInfo, getPath) spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); char *path; int path_len; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } path = spl_filesystem_object_get_path(intern, &path_len TSRMLS_CC); RETURN_STRINGL(path, path_len, 1); @@ -789,6 +812,10 @@ SPL_METHOD(SplFileInfo, getFilename) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); int path_len; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_filesystem_object_get_path(intern, &path_len TSRMLS_CC); @@ -805,6 +832,10 @@ SPL_METHOD(SplFileInfo, getFilename) SPL_METHOD(DirectoryIterator, getFilename) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_STRING(intern->u.dir.entry.d_name, 1); } @@ -865,6 +896,10 @@ SPL_METHOD(SplFileInfo, getPathname) spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); char *path; int path_len; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } path = spl_filesystem_object_get_pathname(intern, &path_len TSRMLS_CC); if (path != NULL) { RETURN_STRINGL(path, path_len, 1); @@ -879,6 +914,10 @@ SPL_METHOD(SplFileInfo, getPathname) SPL_METHOD(FilesystemIterator, key) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (SPL_FILE_DIR_KEY(intern, SPL_FILE_DIR_KEY_AS_FILENAME)) { RETURN_STRING(intern->u.dir.entry.d_name, 1); @@ -894,6 +933,10 @@ SPL_METHOD(FilesystemIterator, key) SPL_METHOD(FilesystemIterator, current) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (SPL_FILE_DIR_CURRENT(intern, SPL_FILE_DIR_CURRENT_AS_PATHNAME)) { spl_filesystem_object_get_file_name(intern TSRMLS_CC); @@ -913,6 +956,10 @@ SPL_METHOD(FilesystemIterator, current) SPL_METHOD(DirectoryIterator, isDot) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_BOOL(spl_filesystem_is_dot(intern->u.dir.entry.d_name)); } @@ -957,6 +1004,9 @@ SPL_METHOD(SplFileInfo, func_name) \ { \ spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); \ zend_error_handling error_handling; \ + if (zend_parse_parameters_none() == FAILURE) { \ + return; \ + } \ \ zend_replace_error_handling(EH_THROW, spl_ce_RuntimeException, &error_handling TSRMLS_CC);\ spl_filesystem_object_get_file_name(intern TSRMLS_CC); \ @@ -1048,6 +1098,10 @@ SPL_METHOD(SplFileInfo, getLinkTarget) int ret; char buff[MAXPATHLEN]; zend_error_handling error_handling; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } zend_replace_error_handling(EH_THROW, spl_ce_RuntimeException, &error_handling TSRMLS_CC); @@ -1093,6 +1147,10 @@ SPL_METHOD(SplFileInfo, getRealPath) char buff[MAXPATHLEN]; char *filename; zend_error_handling error_handling; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } zend_replace_error_handling(EH_THROW, spl_ce_RuntimeException, &error_handling TSRMLS_CC); @@ -1226,6 +1284,10 @@ SPL_METHOD(FilesystemIterator, rewind) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern->u.dir.index = 0; if (intern->u.dir.dirp) { php_stream_rewinddir(intern->u.dir.dirp); @@ -1241,6 +1303,10 @@ SPL_METHOD(FilesystemIterator, rewind) SPL_METHOD(FilesystemIterator, getFlags) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_LONG(intern->flags & (SPL_FILE_DIR_KEY_MODE_MASK | SPL_FILE_DIR_CURRENT_MODE_MASK | SPL_FILE_DIR_OTHERS_MASK)); } /* }}} */ @@ -1252,7 +1318,9 @@ SPL_METHOD(FilesystemIterator, setFlags) spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); long flags; - zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &flags); + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &flags) == FAILURE) { + return; + } intern->flags &= ~(SPL_FILE_DIR_KEY_MODE_MASK|SPL_FILE_DIR_CURRENT_MODE_MASK|SPL_FILE_DIR_OTHERS_MASK); intern->flags |= ((SPL_FILE_DIR_KEY_MODE_MASK|SPL_FILE_DIR_CURRENT_MODE_MASK|SPL_FILE_DIR_OTHERS_MASK) & flags); @@ -1264,13 +1332,13 @@ SPL_METHOD(RecursiveDirectoryIterator, hasChildren) { zend_bool allow_links = 0; spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); - + + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|b", &allow_links) == FAILURE) { + return; + } if (spl_filesystem_is_invalid_or_dot(intern->u.dir.entry.d_name)) { RETURN_FALSE; } else { - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|b", &allow_links) == FAILURE) { - return; - } spl_filesystem_object_get_file_name(intern TSRMLS_CC); if (!allow_links && !(intern->flags & SPL_FILE_DIR_FOLLOW_SYMLINKS)) { php_stat(intern->file_name, intern->file_name_len, FS_IS_LINK, return_value TSRMLS_CC); @@ -1292,6 +1360,10 @@ SPL_METHOD(RecursiveDirectoryIterator, getChildren) spl_filesystem_object *subdir; char slash = SPL_HAS_FLAG(intern->flags, SPL_FILE_DIR_UNIXPATHS) ? '/' : DEFAULT_SLASH; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + spl_filesystem_object_get_file_name(intern TSRMLS_CC); if (SPL_HAS_FLAG(intern->flags, SPL_FILE_DIR_CURRENT_AS_PATHNAME)) { @@ -1324,6 +1396,10 @@ SPL_METHOD(RecursiveDirectoryIterator, getChildren) SPL_METHOD(RecursiveDirectoryIterator, getSubPath) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (intern->u.dir.sub_path) { RETURN_STRINGL(intern->u.dir.sub_path, intern->u.dir.sub_path_len, 1); @@ -1341,6 +1417,10 @@ SPL_METHOD(RecursiveDirectoryIterator, getSubPathname) char *sub_name; int len; char slash = SPL_HAS_FLAG(intern->flags, SPL_FILE_DIR_UNIXPATHS) ? '/' : DEFAULT_SLASH; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (intern->u.dir.sub_path) { len = spprintf(&sub_name, 0, "%s%c%s", intern->u.dir.sub_path, slash, intern->u.dir.entry.d_name); @@ -1372,6 +1452,10 @@ SPL_METHOD(GlobIterator, __construct) SPL_METHOD(GlobIterator, count) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (php_stream_is(intern->u.dir.dirp ,&php_glob_stream_ops)) { RETURN_LONG(php_glob_stream_get_count(intern->u.dir.dirp, NULL)); @@ -2116,6 +2200,10 @@ SPL_METHOD(SplTempFileObject, __construct) SPL_METHOD(SplFileObject, rewind) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_filesystem_file_rewind(getThis(), intern TSRMLS_CC); } /* }}} */ @@ -2125,6 +2213,10 @@ SPL_METHOD(SplFileObject, rewind) SPL_METHOD(SplFileObject, eof) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_BOOL(php_stream_eof(intern->u.file.stream)); } /* }}} */ @@ -2134,6 +2226,10 @@ SPL_METHOD(SplFileObject, eof) SPL_METHOD(SplFileObject, valid) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (SPL_HAS_FLAG(intern->flags, SPL_FILE_OBJECT_READ_AHEAD)) { RETURN_BOOL(intern->u.file.current_line || intern->u.file.current_zval); @@ -2147,6 +2243,10 @@ SPL_METHOD(SplFileObject, valid) SPL_METHOD(SplFileObject, fgets) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (spl_filesystem_file_read(intern, 0 TSRMLS_CC) == FAILURE) { RETURN_FALSE; @@ -2159,6 +2259,10 @@ SPL_METHOD(SplFileObject, fgets) SPL_METHOD(SplFileObject, current) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!intern->u.file.current_line && !intern->u.file.current_zval) { spl_filesystem_file_read_line(getThis(), intern, 1 TSRMLS_CC); @@ -2176,6 +2280,10 @@ SPL_METHOD(SplFileObject, current) SPL_METHOD(SplFileObject, key) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* Do not read the next line to support correct counting with fgetc() if (!intern->current_line) { @@ -2189,6 +2297,10 @@ SPL_METHOD(SplFileObject, key) SPL_METHOD(SplFileObject, next) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_filesystem_file_free_line(intern TSRMLS_CC); if (SPL_HAS_FLAG(intern->flags, SPL_FILE_OBJECT_READ_AHEAD)) { @@ -2212,6 +2324,10 @@ SPL_METHOD(SplFileObject, getFlags) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(intern->flags & SPL_FILE_OBJECT_MASK); } /* }}} */ @@ -2240,6 +2356,10 @@ SPL_METHOD(SplFileObject, setMaxLineLen) SPL_METHOD(SplFileObject, getMaxLineLen) { spl_filesystem_object *intern = (spl_filesystem_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_LONG((long)intern->u.file.max_line_len); } /* }}} */ @@ -2248,6 +2368,10 @@ SPL_METHOD(SplFileObject, getMaxLineLen) Return false */ SPL_METHOD(SplFileObject, hasChildren) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_FALSE; } /* }}} */ @@ -2255,6 +2379,9 @@ SPL_METHOD(SplFileObject, hasChildren) Read NULL */ SPL_METHOD(SplFileObject, getChildren) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* return NULL */ } /* }}} */ diff --git a/ext/spl/spl_dllist.c b/ext/spl/spl_dllist.c index af7389cf65..c4e239576c 100644 --- a/ext/spl/spl_dllist.c +++ b/ext/spl/spl_dllist.c @@ -1043,6 +1043,10 @@ static void spl_dllist_it_move_forward(zend_object_iterator *iter TSRMLS_DC) /* SPL_METHOD(SplDoublyLinkedList, key) { spl_dllist_object *intern = (spl_dllist_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_LONG(intern->traverse_position); } @@ -1053,6 +1057,10 @@ SPL_METHOD(SplDoublyLinkedList, key) SPL_METHOD(SplDoublyLinkedList, prev) { spl_dllist_object *intern = (spl_dllist_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_dllist_it_helper_move_forward(&intern->traverse_pointer, &intern->traverse_position, intern->llist, intern->flags ^ SPL_DLLIST_IT_LIFO TSRMLS_CC); } @@ -1063,6 +1071,10 @@ SPL_METHOD(SplDoublyLinkedList, prev) SPL_METHOD(SplDoublyLinkedList, next) { spl_dllist_object *intern = (spl_dllist_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_dllist_it_helper_move_forward(&intern->traverse_pointer, &intern->traverse_position, intern->llist, intern->flags TSRMLS_CC); } @@ -1073,6 +1085,10 @@ SPL_METHOD(SplDoublyLinkedList, next) SPL_METHOD(SplDoublyLinkedList, valid) { spl_dllist_object *intern = (spl_dllist_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_BOOL(intern->traverse_pointer != NULL); } @@ -1083,6 +1099,10 @@ SPL_METHOD(SplDoublyLinkedList, valid) SPL_METHOD(SplDoublyLinkedList, rewind) { spl_dllist_object *intern = (spl_dllist_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_dllist_it_helper_rewind(&intern->traverse_pointer, &intern->traverse_position, intern->llist, intern->flags TSRMLS_CC); } @@ -1094,6 +1114,10 @@ SPL_METHOD(SplDoublyLinkedList, current) { spl_dllist_object *intern = (spl_dllist_object*)zend_object_store_get_object(getThis() TSRMLS_CC); spl_ptr_llist_element *element = intern->traverse_pointer; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (element == NULL || element->data == NULL) { RETURN_NULL(); diff --git a/ext/spl/spl_heap.c b/ext/spl/spl_heap.c index 6f11ef92cf..f729478388 100644 --- a/ext/spl/spl_heap.c +++ b/ext/spl/spl_heap.c @@ -982,6 +982,10 @@ SPL_METHOD(SplHeap, key) { spl_heap_object *intern = (spl_heap_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(intern->heap->count - 1); } /* }}} */ @@ -992,6 +996,10 @@ SPL_METHOD(SplHeap, next) { spl_heap_object *intern = (spl_heap_object*)zend_object_store_get_object(getThis() TSRMLS_CC); spl_ptr_heap_element elem = spl_ptr_heap_delete_top(intern->heap, getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (elem != NULL) { zval_ptr_dtor((zval **)&elem); @@ -1004,6 +1012,10 @@ SPL_METHOD(SplHeap, next) SPL_METHOD(SplHeap, valid) { spl_heap_object *intern = (spl_heap_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_BOOL(intern->heap->count != 0); } @@ -1013,6 +1025,9 @@ SPL_METHOD(SplHeap, valid) Rewind the datastructure back to the start */ SPL_METHOD(SplHeap, rewind) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* do nothing, the iterator always points to the top element */ } /* }}} */ @@ -1023,6 +1038,10 @@ SPL_METHOD(SplHeap, current) { spl_heap_object *intern = (spl_heap_object*)zend_object_store_get_object(getThis() TSRMLS_CC); zval *element = (zval *)intern->heap->elements[0]; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!intern->heap->count || !element) { RETURN_NULL(); @@ -1038,6 +1057,10 @@ SPL_METHOD(SplPriorityQueue, current) { spl_heap_object *intern = (spl_heap_object*)zend_object_store_get_object(getThis() TSRMLS_CC); zval **element = (zval **)&intern->heap->elements[0]; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!intern->heap->count || !*element) { RETURN_NULL(); diff --git a/ext/spl/spl_iterators.c b/ext/spl/spl_iterators.c index 9c1750b219..1c9486bc3e 100755 --- a/ext/spl/spl_iterators.c +++ b/ext/spl/spl_iterators.c @@ -562,6 +562,10 @@ SPL_METHOD(RecursiveIteratorIterator, __construct) SPL_METHOD(RecursiveIteratorIterator, rewind) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_recursive_it_rewind_ex(object, getThis() TSRMLS_CC); } /* }}} */ @@ -571,6 +575,10 @@ SPL_METHOD(RecursiveIteratorIterator, rewind) SPL_METHOD(RecursiveIteratorIterator, valid) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_BOOL(spl_recursive_it_valid_ex(object, getThis() TSRMLS_CC) == SUCCESS); } /* }}} */ @@ -581,6 +589,10 @@ SPL_METHOD(RecursiveIteratorIterator, key) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); zend_object_iterator *iterator = object->iterators[object->level].iterator; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (iterator->funcs->get_current_key) { char *str_key; @@ -609,6 +621,10 @@ SPL_METHOD(RecursiveIteratorIterator, current) spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); zend_object_iterator *iterator = object->iterators[object->level].iterator; zval **data; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } iterator->funcs->get_current_data(iterator, &data TSRMLS_CC); if (data && *data) { @@ -621,6 +637,10 @@ SPL_METHOD(RecursiveIteratorIterator, current) SPL_METHOD(RecursiveIteratorIterator, next) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_recursive_it_move_forward_ex(object, getThis() TSRMLS_CC); } /* }}} */ @@ -631,6 +651,10 @@ SPL_METHOD(RecursiveIteratorIterator, getDepth) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(object->level); } /* }}} */ @@ -657,6 +681,10 @@ SPL_METHOD(RecursiveIteratorIterator, getInnerIterator) spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); long level = object->level; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_ZVAL(object->iterators[level].zobject, 1, 0); } /* }}} */ @@ -664,6 +692,9 @@ SPL_METHOD(RecursiveIteratorIterator, getInnerIterator) Called when iteration begins (after first rewind() call) */ SPL_METHOD(RecursiveIteratorIterator, beginIteration) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* nothing to do */ } /* }}} */ @@ -671,6 +702,9 @@ SPL_METHOD(RecursiveIteratorIterator, beginIteration) Called when iteration ends (when valid() first returns false */ SPL_METHOD(RecursiveIteratorIterator, endIteration) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* nothing to do */ } /* }}} */ @@ -681,6 +715,10 @@ SPL_METHOD(RecursiveIteratorIterator, callHasChildren) spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); zend_class_entry *ce = object->iterators[object->level].ce; zval *retval, *zobject; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } zobject = object->iterators[object->level].zobject; if (!zobject) { @@ -702,6 +740,10 @@ SPL_METHOD(RecursiveIteratorIterator, callGetChildren) spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); zend_class_entry *ce = object->iterators[object->level].ce; zval *retval, *zobject; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } zobject = object->iterators[object->level].zobject; if (!zobject) { @@ -718,6 +760,9 @@ SPL_METHOD(RecursiveIteratorIterator, callGetChildren) Called when recursing one level down */ SPL_METHOD(RecursiveIteratorIterator, beginChildren) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* nothing to do */ } /* }}} */ @@ -725,6 +770,9 @@ SPL_METHOD(RecursiveIteratorIterator, beginChildren) Called when end recursing one level */ SPL_METHOD(RecursiveIteratorIterator, endChildren) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* nothing to do */ } /* }}} */ @@ -732,6 +780,9 @@ SPL_METHOD(RecursiveIteratorIterator, endChildren) Called when the next element is available */ SPL_METHOD(RecursiveIteratorIterator, nextElement) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* nothing to do */ } /* }}} */ @@ -758,6 +809,10 @@ SPL_METHOD(RecursiveIteratorIterator, getMaxDepth) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + if (object->max_depth == -1) { RETURN_FALSE; } else { @@ -973,7 +1028,7 @@ SPL_METHOD(RecursiveTreeIterator, __construct) spl_recursive_it_it_construct(INTERNAL_FUNCTION_PARAM_PASSTHRU, spl_ce_RecursiveTreeIterator, zend_ce_iterator, RIT_RecursiveTreeIterator); } /* }}} */ -/* {{{ proto void RecursiveTreeIterator::setPrefixPart() throws OutOfRangeException +/* {{{ proto void RecursiveTreeIterator::setPrefixPart(int part, string prefix) throws OutOfRangeException Sets prefix parts as used in getPrefix() */ SPL_METHOD(RecursiveTreeIterator, setPrefixPart) { @@ -1000,6 +1055,9 @@ SPL_METHOD(RecursiveTreeIterator, getPrefix) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_recursive_tree_iterator_get_prefix(object, return_value TSRMLS_CC); } /* }}} */ @@ -1009,6 +1067,10 @@ SPL_METHOD(RecursiveTreeIterator, getEntry) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + spl_recursive_tree_iterator_get_entry(object, return_value TSRMLS_CC); } /* }}} */ @@ -1018,6 +1080,10 @@ SPL_METHOD(RecursiveTreeIterator, getPostfix) { spl_recursive_it_object *object = (spl_recursive_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + spl_recursive_tree_iterator_get_postfix(object, return_value TSRMLS_CC); } /* }}} */ @@ -1029,6 +1095,10 @@ SPL_METHOD(RecursiveTreeIterator, current) zval prefix, entry, postfix; char *str, *ptr; size_t str_len; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (object->flags & RTIT_BYPASS_CURRENT) { zend_object_iterator *iterator = object->iterators[object->level].iterator; @@ -1074,6 +1144,10 @@ SPL_METHOD(RecursiveTreeIterator, key) zval prefix, key, postfix, key_copy; char *str, *ptr; size_t str_len; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (iterator->funcs->get_current_key) { char *str_key; @@ -1440,6 +1514,10 @@ SPL_METHOD(dual_it, getInnerIterator) spl_dual_it_object *intern; intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (intern->inner.zobject) { RETVAL_ZVAL(intern->inner.zobject, 1, 0); @@ -1540,6 +1618,11 @@ SPL_METHOD(dual_it, rewind) spl_dual_it_object *intern; intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } + spl_dual_it_rewind(intern TSRMLS_CC); spl_dual_it_fetch(intern, 1 TSRMLS_CC); } /* }}} */ @@ -1553,6 +1636,10 @@ SPL_METHOD(dual_it, valid) { spl_dual_it_object *intern; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); RETURN_BOOL(intern->current.data); @@ -1570,6 +1657,10 @@ SPL_METHOD(dual_it, key) { spl_dual_it_object *intern; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); if (intern->current.data) { @@ -1593,6 +1684,10 @@ SPL_METHOD(dual_it, key) SPL_METHOD(dual_it, current) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -1610,6 +1705,10 @@ SPL_METHOD(dual_it, current) SPL_METHOD(dual_it, next) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -1655,6 +1754,10 @@ static inline void spl_filter_it_next(zval *zthis, spl_dual_it_object *intern TS SPL_METHOD(FilterIterator, rewind) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); spl_filter_it_rewind(getThis(), intern TSRMLS_CC); @@ -1665,6 +1768,10 @@ SPL_METHOD(FilterIterator, rewind) SPL_METHOD(FilterIterator, next) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); spl_filter_it_next(getThis(), intern TSRMLS_CC); @@ -1683,6 +1790,10 @@ SPL_METHOD(RecursiveFilterIterator, hasChildren) { spl_dual_it_object *intern; zval *retval; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -1700,6 +1811,10 @@ SPL_METHOD(RecursiveFilterIterator, getChildren) { spl_dual_it_object *intern; zval *retval; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -1736,6 +1851,10 @@ SPL_METHOD(RegexIterator, accept) int subject_len, use_copy, count = 0, result_len; zval subject_copy, zcount, *replacement; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + if (intern->current.data == NULL) { RETURN_FALSE; } @@ -1829,6 +1948,10 @@ SPL_METHOD(RegexIterator, getMode) { spl_dual_it_object *intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(intern->u.regex.mode); } /* }}} */ @@ -1857,6 +1980,10 @@ SPL_METHOD(RegexIterator, getFlags) { spl_dual_it_object *intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(intern->u.regex.flags); } /* }}} */ @@ -1879,6 +2006,10 @@ SPL_METHOD(RegexIterator, setFlags) SPL_METHOD(RegexIterator, getPregFlags) { spl_dual_it_object *intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (intern->u.regex.use_flags) { RETURN_LONG(intern->u.regex.preg_flags); @@ -1915,6 +2046,10 @@ SPL_METHOD(RecursiveRegexIterator, getChildren) { spl_dual_it_object *intern; zval *retval, *regex; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2355,6 +2490,10 @@ SPL_METHOD(CachingIterator, __construct) SPL_METHOD(CachingIterator, rewind) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2366,6 +2505,10 @@ SPL_METHOD(CachingIterator, rewind) SPL_METHOD(CachingIterator, valid) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2377,6 +2520,10 @@ SPL_METHOD(CachingIterator, valid) SPL_METHOD(CachingIterator, next) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2388,6 +2535,10 @@ SPL_METHOD(CachingIterator, next) SPL_METHOD(CachingIterator, hasNext) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2532,6 +2683,10 @@ SPL_METHOD(CachingIterator, getCache) { spl_dual_it_object *intern; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); if (!(intern->u.caching.flags & CIT_FULL_CACHE)) { @@ -2549,6 +2704,10 @@ SPL_METHOD(CachingIterator, getFlags) { spl_dual_it_object *intern; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); RETURN_LONG(intern->u.caching.flags); @@ -2594,6 +2753,10 @@ SPL_METHOD(CachingIterator, count) { spl_dual_it_object *intern; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); if (!(intern->u.caching.flags & CIT_FULL_CACHE)) { @@ -2657,6 +2820,10 @@ SPL_METHOD(RecursiveCachingIterator, hasChildren) { spl_dual_it_object *intern; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); RETURN_BOOL(intern->u.caching.zchildren); @@ -2667,6 +2834,10 @@ SPL_METHOD(RecursiveCachingIterator, hasChildren) SPL_METHOD(RecursiveCachingIterator, getChildren) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2722,6 +2893,9 @@ SPL_METHOD(NoRewindIterator, __construct) Prevent a call to inner iterators rewind() */ SPL_METHOD(NoRewindIterator, rewind) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } /* nothing to do */ } /* }}} */ @@ -2730,6 +2904,10 @@ SPL_METHOD(NoRewindIterator, rewind) SPL_METHOD(NoRewindIterator, valid) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); RETURN_BOOL(intern->inner.iterator->funcs->valid(intern->inner.iterator TSRMLS_CC) == SUCCESS); @@ -2740,6 +2918,10 @@ SPL_METHOD(NoRewindIterator, valid) SPL_METHOD(NoRewindIterator, key) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2768,6 +2950,10 @@ SPL_METHOD(NoRewindIterator, current) { spl_dual_it_object *intern; zval **data; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); intern->inner.iterator->funcs->get_current_data(intern->inner.iterator, &data TSRMLS_CC); @@ -2781,6 +2967,10 @@ SPL_METHOD(NoRewindIterator, current) SPL_METHOD(NoRewindIterator, next) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); intern->inner.iterator->funcs->move_forward(intern->inner.iterator TSRMLS_CC); @@ -2813,6 +3003,10 @@ SPL_METHOD(InfiniteIterator, __construct) SPL_METHOD(InfiniteIterator, next) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2837,12 +3031,18 @@ static const zend_function_entry spl_funcs_InfiniteIterator[] = { Does nothing */ SPL_METHOD(EmptyIterator, rewind) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } } /* }}} */ /* {{{ proto false EmptyIterator::valid() Return false */ SPL_METHOD(EmptyIterator, valid) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_FALSE; } /* }}} */ @@ -2850,6 +3050,9 @@ SPL_METHOD(EmptyIterator, valid) Throws exception BadMethodCallException */ SPL_METHOD(EmptyIterator, key) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } zend_throw_exception(spl_ce_BadMethodCallException, "Accessing the key of an EmptyIterator", 0 TSRMLS_CC); } /* }}} */ @@ -2857,6 +3060,9 @@ SPL_METHOD(EmptyIterator, key) Throws exception BadMethodCallException */ SPL_METHOD(EmptyIterator, current) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } zend_throw_exception(spl_ce_BadMethodCallException, "Accessing the value of an EmptyIterator", 0 TSRMLS_CC); } /* }}} */ @@ -2864,6 +3070,9 @@ SPL_METHOD(EmptyIterator, current) Does nothing */ SPL_METHOD(EmptyIterator, next) { + if (zend_parse_parameters_none() == FAILURE) { + return; + } } /* }}} */ static const zend_function_entry spl_funcs_EmptyIterator[] = { @@ -2963,6 +3172,10 @@ SPL_METHOD(AppendIterator, append) SPL_METHOD(AppendIterator, rewind) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2978,6 +3191,10 @@ SPL_METHOD(AppendIterator, valid) { spl_dual_it_object *intern; + if (zend_parse_parameters_none() == FAILURE) { + return; + } + intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); RETURN_BOOL(intern->current.data); @@ -2988,6 +3205,10 @@ SPL_METHOD(AppendIterator, valid) SPL_METHOD(AppendIterator, next) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -2999,6 +3220,10 @@ SPL_METHOD(AppendIterator, next) SPL_METHOD(AppendIterator, getIteratorIndex) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); @@ -3011,6 +3236,10 @@ SPL_METHOD(AppendIterator, getIteratorIndex) SPL_METHOD(AppendIterator, getArrayIterator) { spl_dual_it_object *intern; + + if (zend_parse_parameters_none() == FAILURE) { + return; + } intern = (spl_dual_it_object*)zend_object_store_get_object(getThis() TSRMLS_CC); diff --git a/ext/spl/spl_observer.c b/ext/spl/spl_observer.c index 4c6ec42eaf..2e9ad4f7dc 100755 --- a/ext/spl/spl_observer.c +++ b/ext/spl/spl_observer.c @@ -504,6 +504,10 @@ SPL_METHOD(SplObjectStorage, count) { spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(zend_hash_num_elements(&intern->storage)); } /* }}} */ @@ -513,6 +517,10 @@ SPL_METHOD(SplObjectStorage, rewind) { spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + zend_hash_internal_pointer_reset_ex(&intern->storage, &intern->pos); intern->index = 0; } /* }}} */ @@ -523,6 +531,10 @@ SPL_METHOD(SplObjectStorage, valid) { spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_BOOL(zend_hash_has_more_elements_ex(&intern->storage, &intern->pos) == SUCCESS); } /* }}} */ @@ -532,6 +544,10 @@ SPL_METHOD(SplObjectStorage, key) { spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + RETURN_LONG(intern->index); } /* }}} */ @@ -542,6 +558,10 @@ SPL_METHOD(SplObjectStorage, current) spl_SplObjectStorageElement *element; spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + if (zend_hash_get_current_data_ex(&intern->storage, (void**)&element, &intern->pos) == FAILURE) { return; } @@ -554,6 +574,10 @@ SPL_METHOD(SplObjectStorage, getInfo) { spl_SplObjectStorageElement *element; spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (zend_hash_get_current_data_ex(&intern->storage, (void**)&element, &intern->pos) == FAILURE) { return; @@ -587,6 +611,10 @@ SPL_METHOD(SplObjectStorage, next) { spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + zend_hash_move_forward_ex(&intern->storage, &intern->pos); intern->index++; } /* }}} */ @@ -603,8 +631,12 @@ SPL_METHOD(SplObjectStorage, serialize) php_serialize_data_t var_hash; smart_str buf = {0}; - PHP_VAR_SERIALIZE_INIT(var_hash); + if (zend_parse_parameters_none() == FAILURE) { + return; + } + PHP_VAR_SERIALIZE_INIT(var_hash); + /* storage */ smart_str_appendl(&buf, "x:i:", 4); smart_str_append_long(&buf, zend_hash_num_elements(&intern->storage)); @@ -852,6 +884,10 @@ SPL_METHOD(MultipleIterator, __construct) SPL_METHOD(MultipleIterator, getFlags) { spl_SplObjectStorage *intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } RETURN_LONG(intern->flags); } /* }}} */ @@ -915,6 +951,10 @@ SPL_METHOD(MultipleIterator, rewind) zval *it; intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } zend_hash_internal_pointer_reset_ex(&intern->storage, &intern->pos); while (zend_hash_get_current_data_ex(&intern->storage, (void**)&element, &intern->pos) == SUCCESS && !EG(exception)) { @@ -934,6 +974,10 @@ SPL_METHOD(MultipleIterator, next) zval *it; intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } zend_hash_internal_pointer_reset_ex(&intern->storage, &intern->pos); while (zend_hash_get_current_data_ex(&intern->storage, (void**)&element, &intern->pos) == SUCCESS && !EG(exception)) { @@ -954,6 +998,10 @@ SPL_METHOD(MultipleIterator, valid) long expect, valid; intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } if (!zend_hash_num_elements(&intern->storage)) { RETURN_FALSE; @@ -1058,6 +1106,10 @@ SPL_METHOD(MultipleIterator, current) { spl_SplObjectStorage *intern; intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_multiple_iterator_get_all(intern, SPL_MULTIPLE_ITERATOR_GET_ALL_CURRENT, return_value TSRMLS_CC); } @@ -1069,6 +1121,10 @@ SPL_METHOD(MultipleIterator, key) { spl_SplObjectStorage *intern; intern = (spl_SplObjectStorage*)zend_object_store_get_object(getThis() TSRMLS_CC); + + if (zend_parse_parameters_none() == FAILURE) { + return; + } spl_multiple_iterator_get_all(intern, SPL_MULTIPLE_ITERATOR_GET_ALL_KEY, return_value TSRMLS_CC); } diff --git a/ext/spl/tests/arrayObject_count_basic1.phpt b/ext/spl/tests/arrayObject_count_basic1.phpt index 1a3b84d509..a003c2cf67 100644 --- a/ext/spl/tests/arrayObject_count_basic1.phpt +++ b/ext/spl/tests/arrayObject_count_basic1.phpt @@ -67,7 +67,9 @@ int(99) int(2) int(99) int(1) -int(1) + +Warning: ArrayObject::count() expects exactly 0 parameters, 1 given in %s on line %d +NULL ==ArrayIterator== int(99) int(0) @@ -77,4 +79,6 @@ int(99) int(2) int(99) int(1) -int(1) \ No newline at end of file + +Warning: ArrayIterator::count() expects exactly 0 parameters, 1 given in %s on line %d +NULL \ No newline at end of file diff --git a/ext/spl/tests/fileobject_005.phpt b/ext/spl/tests/fileobject_005.phpt index b3882e940f..fa9e6db173 100644 --- a/ext/spl/tests/fileobject_005.phpt +++ b/ext/spl/tests/fileobject_005.phpt @@ -33,8 +33,10 @@ unlink($path); ?> --EXPECTF-- bool(true) -string(4) "blah" + +Warning: SplFileObject::fgets() expects exactly 0 parameters, 1 given in %s on line %d +NULL Warning: SplFileObject::ftruncate() expects exactly 1 parameter, 0 given in %s on line %d NULL -==DONE== +==DONE== \ No newline at end of file