From: Victor Stinner <victor.stinner@gmail.com>
Date: Tue, 30 Sep 2014 16:08:36 +0000 (+0200)
Subject: Issue #22448: asyncio, cleanup _run_once(), only iterate once to remove delayed
X-Git-Tag: v3.5.0a1~813^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=68da8fc4c0b4b2f640bd09b7b0e3214b263fac0d;p=python

Issue #22448: asyncio, cleanup _run_once(), only iterate once to remove delayed
calls that were cancelled.
---

diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py
index 5aaf58f9f1..3cff72abb5 100644
--- a/Lib/asyncio/base_events.py
+++ b/Lib/asyncio/base_events.py
@@ -994,19 +994,22 @@ class BaseEventLoop(events.AbstractEventLoop):
         'call_later' callbacks.
         """
 
-        # Remove delayed calls that were cancelled if their number is too high
         sched_count = len(self._scheduled)
         if (sched_count > _MIN_SCHEDULED_TIMER_HANDLES and
             self._timer_cancelled_count / sched_count >
                 _MIN_CANCELLED_TIMER_HANDLES_FRACTION):
+            # Remove delayed calls that were cancelled if their number
+            # is too high
+            new_scheduled = []
             for handle in self._scheduled:
                 if handle._cancelled:
                     handle._scheduled = False
+                else:
+                    new_scheduled.append(handle)
 
-            self._scheduled = [x for x in self._scheduled if not x._cancelled]
+            heapq.heapify(new_scheduled)
+            self._scheduled = new_scheduled
             self._timer_cancelled_count = 0
-
-            heapq.heapify(self._scheduled)
         else:
             # Remove delayed calls that were cancelled from head of queue.
             while self._scheduled and self._scheduled[0]._cancelled: