From: Richard Smith <richard-llvm@metafoo.co.uk>
Date: Fri, 17 Jul 2015 19:51:03 +0000 (+0000)
Subject: Remove redundant bouncing between StringRef and a pair of 'const char *'.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=689e9e0ebaecd6a58711eb94350b6f24d43c6455;p=clang

Remove redundant bouncing between StringRef and a pair of 'const char *'.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@242562 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/clang/Serialization/ASTReader.h b/include/clang/Serialization/ASTReader.h
index 38a552405e..029b3570c5 100644
--- a/include/clang/Serialization/ASTReader.h
+++ b/include/clang/Serialization/ASTReader.h
@@ -1755,10 +1755,7 @@ public:
   /// declarations with this name are visible from translation unit scope, their
   /// declarations will be deserialized and introduced into the declaration
   /// chain of the identifier.
-  virtual IdentifierInfo *get(const char *NameStart, const char *NameEnd);
-  IdentifierInfo *get(StringRef Name) override {
-    return get(Name.begin(), Name.end());
-  }
+  IdentifierInfo *get(StringRef Name) override;
 
   /// \brief Retrieve an iterator into the set of all identifiers
   /// in all loaded AST files.
diff --git a/lib/Serialization/ASTReader.cpp b/lib/Serialization/ASTReader.cpp
index 9fbf55bf15..96f6ca5cb0 100644
--- a/lib/Serialization/ASTReader.cpp
+++ b/lib/Serialization/ASTReader.cpp
@@ -6824,10 +6824,9 @@ void ASTReader::UpdateSema() {
     SemaObj->ActOnPragmaOptimize(/* IsOn = */ false, OptimizeOffPragmaLocation);
 }
 
-IdentifierInfo* ASTReader::get(const char *NameStart, const char *NameEnd) {
+IdentifierInfo *ASTReader::get(StringRef Name) {
   // Note that we are loading an identifier.
   Deserializing AnIdentifier(this);
-  StringRef Name(NameStart, NameEnd - NameStart);
 
   // If there is a global index, look there first to determine which modules
   // provably do not have any results for this identifier.