From: John Stebbins <jstebbins.hb@gmail.com>
Date: Mon, 11 Feb 2019 15:04:24 +0000 (-0700)
Subject: scan: fix potential buffer overflow in sprintf
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=67299770c013120ffdc4d86daffc9c48691ab802;p=handbrake

scan: fix potential buffer overflow in sprintf

Use snprintf
---

diff --git a/libhb/scan.c b/libhb/scan.c
index 5d97b27d1..f1e0de230 100644
--- a/libhb/scan.c
+++ b/libhb/scan.c
@@ -1297,21 +1297,20 @@ static void LookForAudio(hb_scan_t *scan, hb_title_t * title, hb_buffer_t * b)
                 break;
         }
     }
-
     if (codec_name != NULL && profile_name != NULL)
     {
-        sprintf(audio->config.lang.description, "%s (%s %s)",
-                audio->config.lang.simple, codec_name, profile_name);
+        snprintf(audio->config.lang.description, sizeof(audio->config.lang.description),
+                "%s (%s %s)", audio->config.lang.simple, codec_name, profile_name);
     }
     else if (codec_name != NULL)
     {
-        sprintf(audio->config.lang.description, "%s (%s)",
-                audio->config.lang.simple, codec_name);
+        snprintf(audio->config.lang.description, sizeof(audio->config.lang.description),
+                "%s (%s)", audio->config.lang.simple, codec_name);
     }
     else if (profile_name != NULL)
     {
-        sprintf(audio->config.lang.description, "%s (%s)",
-                audio->config.lang.simple, profile_name);
+        snprintf(audio->config.lang.description, sizeof(audio->config.lang.description),
+                "%s (%s)", audio->config.lang.simple, profile_name);
     }
 
     if (audio->config.lang.attributes & HB_AUDIO_ATTR_VISUALLY_IMPAIRED)