From: Magnus Hagander <magnus@hagander.net>
Date: Sat, 28 Jan 2012 09:01:17 +0000 (+0100)
Subject: Prevent logging "failed to stat file: success" for temp files
X-Git-Tag: REL9_2_BETA1~515
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=672614cf2137b2a3778c69de8d73770d84790e44;p=postgresql

Prevent logging "failed to stat file: success" for temp files

This was broken in commit bc3347484a7bf9eddb98e4352d84599cae9a31c6, the
addition of statistics counters for temp files.

Reported by Thom Brown
---

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index 6bad6bfe7d..52d9b6da94 100644
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -1128,11 +1128,11 @@ FileClose(File file)
 									vfdP->fileName,
 									(unsigned long) filestats.st_size)));
 			}
-			else
-			{
-				errno = stat_errno;
-				elog(LOG, "could not stat file \"%s\": %m", vfdP->fileName);
-			}
+		}
+		else
+		{
+			errno = stat_errno;
+			elog(LOG, "could not stat file \"%s\": %m", vfdP->fileName);
 		}
 	}