From: Daniel Gustafsson <daniel@yesql.se>
Date: Thu, 20 Jun 2019 10:19:41 +0000 (+0200)
Subject: nss: don't set unused parameter
X-Git-Tag: curl-7_65_2~30
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=67171025031184bb86703746422a88573d9ef3c1;p=curl

nss: don't set unused parameter

The value of the maxPTDs parameter to PR_Init() has since at least
NSPR 2.1, which was released sometime in 1998, been marked ignored
as is accordingly not used in the initialization code.  Setting it
to a value when calling PR_Init() is thus benign, but indicates an
intent which may be misleading. Reset the value to zero to improve
clarity.

Closes https://github.com/curl/curl/pull/4054
---

diff --git a/lib/vtls/nss.c b/lib/vtls/nss.c
index 7a5213b2b..5e0cd2414 100644
--- a/lib/vtls/nss.c
+++ b/lib/vtls/nss.c
@@ -1423,7 +1423,7 @@ static int Curl_nss_init(void)
 {
   /* curl_global_init() is not thread-safe so this test is ok */
   if(nss_initlock == NULL) {
-    PR_Init(PR_USER_THREAD, PR_PRIORITY_NORMAL, 256);
+    PR_Init(PR_USER_THREAD, PR_PRIORITY_NORMAL, 0);
     nss_initlock = PR_NewLock();
     nss_crllock = PR_NewLock();
     nss_findslot_lock = PR_NewLock();