From: Aaron Ballman <aaron@aaronballman.com>
Date: Thu, 15 Sep 2016 14:12:33 +0000 (+0000)
Subject: Reverting r281609; it caused some build bots to break.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6701aa355393ccd4e32d813834393693bf90f5ca;p=clang

Reverting r281609; it caused some build bots to break.

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/20061/steps/test/logs/stdio

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@281612 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp
index f3f204ffa0..81dc23724e 100644
--- a/lib/Sema/SemaChecking.cpp
+++ b/lib/Sema/SemaChecking.cpp
@@ -3240,17 +3240,8 @@ bool Sema::SemaBuiltinVAStartImpl(CallExpr *TheCall) {
     Diag(TheCall->getArg(1)->getLocStart(),
          diag::warn_second_arg_of_va_start_not_last_named_param);
   else if (IsCRegister || Type->isReferenceType() ||
-           Type->isSpecificBuiltinType(BuiltinType::Float) || [=] {
-             // Promotable integers are UB, but enumerations need a bit of
-             // extra checking to see what their promotable type actually is.
-             if (!Type->isPromotableIntegerType())
-               return false;
-             if (!Type->isEnumeralType())
-               return true;
-             const EnumDecl *ED = Type->getAs<EnumType>()->getDecl();
-             return !(ED &&
-                      Context.typesAreCompatible(ED->getPromotionType(), Type));
-           }()) {
+           Type->isPromotableIntegerType() ||
+           Type->isSpecificBuiltinType(BuiltinType::Float)) {
     unsigned Reason = 0;
     if (Type->isReferenceType())  Reason = 1;
     else if (IsCRegister)         Reason = 2;
diff --git a/test/Sema/varargs.c b/test/Sema/varargs.c
index 27d49ea1f2..457d84c212 100644
--- a/test/Sema/varargs.c
+++ b/test/Sema/varargs.c
@@ -1,6 +1,5 @@
-// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i386-pc-unknown
+// RUN: %clang_cc1 -fsyntax-only -verify %s
 // RUN: %clang_cc1 -fsyntax-only -verify %s -triple x86_64-apple-darwin9
-// RUN: %clang_cc1 -fsyntax-only -fms-compatibility -DMS -verify %s
 
 void f1(int a)
 {
@@ -95,20 +94,3 @@ void f12(register int i, ...) {  // expected-note {{parameter of type 'int' is d
   __builtin_va_start(ap, i); // expected-warning {{passing a parameter declared with the 'register' keyword to 'va_start' has undefined behavior}}
   __builtin_va_end(ap);
 }
-
-enum __attribute__((packed)) E1 {
-  one1
-};
-
-void f13(enum E1 e, ...) {
-  __builtin_va_list va;
-  __builtin_va_start(va, e);
-#ifndef MS
-  // In Microsoft compatibility mode, all enum types are int, but in
-  // non-ms-compatibility mode, this enumeration type will undergo default
-  // argument promotions.
-  // expected-note@-7 {{parameter of type 'enum E1' is declared here}}
-  // expected-warning@-6 {{passing an object that undergoes default argument promotion to 'va_start' has undefined behavior}}
-#endif
-  __builtin_va_end(va);
-}