From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 27 Apr 2011 18:39:20 +0000 (+0200)
Subject: timeline is not needed in BaseBackup()
X-Git-Tag: REL9_1_BETA1~4
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6693eb72c014e5e8bc2f7f3221ebd5507fdbe8ec;p=postgresql

timeline is not needed in BaseBackup()

This code was accidentally part of the patch, it's only
needed for the code that's for 9.2. Not needing the timeline
also removes the need to call IDENTIFY_SYSTEM.

Noted by Peter E.
---

diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
index aeec8136c4..a5d9c2e652 100644
--- a/src/bin/pg_basebackup/pg_basebackup.c
+++ b/src/bin/pg_basebackup/pg_basebackup.c
@@ -756,7 +756,6 @@ static void
 BaseBackup(void)
 {
 	PGresult   *res;
-	uint32		timeline;
 	char		current_path[MAXPGPATH];
 	char		escaped_label[MAXPGPATH];
 	int			i;
@@ -768,25 +767,6 @@ BaseBackup(void)
 	 */
 	conn = GetConnection();
 
-	/*
-	 * Run IDENFITY_SYSTEM so we can get the timeline
-	 */
-	res = PQexec(conn, "IDENTIFY_SYSTEM");
-	if (PQresultStatus(res) != PGRES_TUPLES_OK)
-	{
-		fprintf(stderr, _("%s: could not identify system: %s\n"),
-				progname, PQerrorMessage(conn));
-		disconnect_and_exit(1);
-	}
-	if (PQntuples(res) != 1)
-	{
-		fprintf(stderr, _("%s: could not identify system, got %i rows\n"),
-				progname, PQntuples(res));
-		disconnect_and_exit(1);
-	}
-	timeline = atoi(PQgetvalue(res, 0, 1));
-	PQclear(res);
-
 	/*
 	 * Start the actual backup
 	 */