From: Guido van Rossum <guido@python.org>
Date: Thu, 26 Mar 1998 22:12:22 +0000 (+0000)
Subject: Don't write "if self.dict: self.dict.close()"; just write
X-Git-Tag: v1.5.1~297
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=65e5399081e23d7b1efbf685096c65d0a0ab912b;p=python

Don't write "if self.dict: self.dict.close()"; just write
"self.dict.close()" and ignore the exception.  The "if self.dict:"
part would be calculated through len(self.dict.keys()), which is very
expensive for a large dictionary...
---

diff --git a/Lib/shelve.py b/Lib/shelve.py
index 9b65a0911f..6bdc0305dd 100644
--- a/Lib/shelve.py
+++ b/Lib/shelve.py
@@ -75,8 +75,7 @@ class Shelf:
 	
 	def close(self):
 		try:
-			if self.dict:
-				self.dict.close()
+                    self.dict.close()
 		except:
 			pass
 		self.dict = 0