From: Tsuda Kageyu Date: Thu, 19 Jun 2014 07:53:29 +0000 (+0900) Subject: Added a check for patternSize and removed a useless check. X-Git-Tag: v1.10beta~168^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=653b631aea231d6cd9ec8825f55495d2280bbe63;p=taglib Added a check for patternSize and removed a useless check. --- diff --git a/taglib/toolkit/tbytevector.cpp b/taglib/toolkit/tbytevector.cpp index 9522f0af..1ecd93d4 100644 --- a/taglib/toolkit/tbytevector.cpp +++ b/taglib/toolkit/tbytevector.cpp @@ -109,7 +109,7 @@ int findChar( char c, uint offset, int byteAlign) { const size_t dataSize = dataEnd - dataBegin; - if(dataSize == 0 || offset + 1 > dataSize) + if(offset + 1 > dataSize) return -1; // n % 0 is invalid @@ -137,7 +137,7 @@ int findVector( { const size_t dataSize = dataEnd - dataBegin; const size_t patternSize = patternEnd - patternBegin; - if(dataSize == 0 || offset + patternSize > dataSize) + if(patternSize == 0 || offset + patternSize > dataSize) return -1; // n % 0 is invalid