From: Rob Richards <rrichards@php.net>
Date: Fri, 2 Jun 2006 16:15:58 +0000 (+0000)
Subject: idness not valid for attribute declarations
X-Git-Tag: BEFORE_NEW_OUTPUT_API~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=653007cea0bb87ccd39a746c7867eb10d907fd81;p=php

idness not valid for attribute declarations
---

diff --git a/ext/dom/element.c b/ext/dom/element.c
index cd582ee0ab..df95e877b0 100644
--- a/ext/dom/element.c
+++ b/ext/dom/element.c
@@ -954,7 +954,7 @@ PHP_FUNCTION(dom_element_set_id_attribute)
 	}
 
 	attrp = xmlHasNsProp(nodep, name, NULL);
-	if (attrp == NULL) {
+	if (attrp == NULL || attrp->type == XML_ATTRIBUTE_DECL) {
 		php_dom_throw_error(NOT_FOUND_ERR, dom_get_strict_error(intern->document) TSRMLS_CC);
 	} else {
 		php_set_attribute_id(attrp, is_id);
@@ -991,7 +991,7 @@ PHP_FUNCTION(dom_element_set_id_attribute_ns)
 	}
 
 	attrp = xmlHasNsProp(elemp, name, uri);
-	if (attrp == NULL) {
+	if (attrp == NULL || attrp->type == XML_ATTRIBUTE_DECL) {
 		php_dom_throw_error(NOT_FOUND_ERR, dom_get_strict_error(intern->document) TSRMLS_CC);
 	} else {
 		php_set_attribute_id(attrp, is_id);