From: Marcel Raad <Marcel.Raad@teamviewer.com>
Date: Fri, 18 Oct 2019 06:19:47 +0000 (+0200)
Subject: examples/sslbackend: fix -Wchar-subscripts warning
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=650677461fb95481f02a55f02c356b0d6ce2de52;p=curl

examples/sslbackend: fix -Wchar-subscripts warning

With the `isdigit` implementation that comes with MSYS2, the argument
is used as an array subscript, resulting in a -Wchar-subscripts
warning. `isdigit`'s behavior is undefined if the argument is negative
and not EOF [0]. As done in lib/curl_ctype.h, cast the `char` variable
to `unsigned char` to avoid that.

[0] https://en.cppreference.com/w/c/string/byte/isdigit

Closes https://github.com/curl/curl/pull/4503
---

diff --git a/docs/examples/sslbackend.c b/docs/examples/sslbackend.c
index c1489a9aa..bbfa81738 100644
--- a/docs/examples/sslbackend.c
+++ b/docs/examples/sslbackend.c
@@ -56,7 +56,7 @@ int main(int argc, char **argv)
 
     return 0;
   }
-  else if(isdigit(*name)) {
+  else if(isdigit((int)(unsigned char)*name)) {
     int id = atoi(name);
 
     result = curl_global_sslset((curl_sslbackend)id, NULL, NULL);