From: Bill Stoddard <stoddard@apache.org>
Date: Sun, 13 Feb 2000 00:39:04 +0000 (+0000)
Subject: Set up return codes correctly in the failure case.
X-Git-Tag: 1.3.12~23
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6461b73f2138a8bbb35e2db31fd18cd550ba9843;p=apache

Set up return codes correctly in the failure case.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@84617 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/generators/mod_cgi.c b/modules/generators/mod_cgi.c
index 67d4197025..e96545cf77 100644
--- a/modules/generators/mod_cgi.c
+++ b/modules/generators/mod_cgi.c
@@ -329,24 +329,24 @@ static ap_status_t run_cgi_child(BUFF **script_out, BUFF **script_in, BUFF **scr
     /* Transumute ourselves into the script.
      * NB only ISINDEX scripts get decoded arguments.
      */
-    if ((ap_createprocattr_init(&procattr, p) != APR_SUCCESS) ||
-        (ap_setprocattr_io(procattr, 
-                           APR_FULL_BLOCK, 
-                           APR_FULL_BLOCK,
-                           APR_FULL_BLOCK) != APR_SUCCESS) ||
-        (ap_setprocattr_dir(procattr, ap_make_dirstr_parent(r->pool, r->filename))        != APR_SUCCESS) ||
-        (ap_setprocattr_cmdtype(procattr, APR_PROGRAM)    != APR_SUCCESS)) {
+    if (((rc = ap_createprocattr_init(&procattr, p)) != APR_SUCCESS) ||
+        ((rc = ap_setprocattr_io(procattr, 
+                                 APR_FULL_BLOCK, 
+                                 APR_FULL_BLOCK,
+                                 APR_FULL_BLOCK)) != APR_SUCCESS) ||
+        ((rc = ap_setprocattr_dir(procattr, 
+                                  ap_make_dirstr_parent(r->pool, r->filename))) != APR_SUCCESS) ||
+        ((rc = ap_setprocattr_cmdtype(procattr, APR_PROGRAM)) != APR_SUCCESS)) {
         /* Something bad happened, tell the world. */
-	ap_log_rerror(APLOG_MARK, APLOG_ERR, errno, r,
+	ap_log_rerror(APLOG_MARK, APLOG_ERR, rc, r,
 		      "couldn't create child process: %s", r->filename);
-        rc = !APR_SUCCESS;
     }
     else {
         rc = ap_create_process(&procnew, command, argv, env, procattr, p);
     
         if (rc != APR_SUCCESS) {
             /* Bad things happened. Everyone should have cleaned up. */
-            ap_log_rerror(APLOG_MARK, APLOG_ERR, errno, r,
+            ap_log_rerror(APLOG_MARK, APLOG_ERR, rc, r,
                         "couldn't create child process: %d: %s", rc, r->filename);
         }
         else {