From: Tim Peters <tim@python.org>
Date: Wed, 9 Oct 2013 01:55:51 +0000 (-0500)
Subject: Issue 19158:  a rare race in BoundedSemaphore could allow .release() too often.
X-Git-Tag: v2.7.6rc1~58
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=641d6217a839f42ccac6478ff7272dfef5c807e4;p=python

Issue 19158:  a rare race in BoundedSemaphore could allow .release() too often.
(grafted from e06edc0c7a4951327f0c95ebeebccba6879a6063)
---

diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py
index 5a765f3208..ac0b4bc701 100644
--- a/Lib/test/test_threading.py
+++ b/Lib/test/test_threading.py
@@ -466,6 +466,23 @@ class ThreadTests(BaseTestCase):
         finally:
             sys.setcheckinterval(old_interval)
 
+    def test_BoundedSemaphore_limit(self):
+        # BoundedSemaphore should raise ValueError if released too often.
+        for limit in range(1, 10):
+            bs = threading.BoundedSemaphore(limit)
+            threads = [threading.Thread(target=bs.acquire)
+                       for _ in range(limit)]
+            for t in threads:
+                t.start()
+            for t in threads:
+                t.join()
+            threads = [threading.Thread(target=bs.release)
+                       for _ in range(limit)]
+            for t in threads:
+                t.start()
+            for t in threads:
+                t.join()
+            self.assertRaises(ValueError, bs.release)
 
 class ThreadJoinOnShutdown(BaseTestCase):
 
diff --git a/Lib/threading.py b/Lib/threading.py
index 72c83197fd..167f8c7fe3 100644
--- a/Lib/threading.py
+++ b/Lib/threading.py
@@ -531,9 +531,11 @@ class _BoundedSemaphore(_Semaphore):
         raise a ValueError.
 
         """
-        if self._Semaphore__value >= self._initial_value:
-            raise ValueError("Semaphore released too many times")
-        return _Semaphore.release(self)
+        with self._cond:
+            if self._value >= self._initial_value:
+                raise ValueError("Semaphore released too many times")
+            self._value += 1
+            self._cond.notify()
 
 
 def Event(*args, **kwargs):