From: Argyrios Kyrtzidis <akyrtzi@gmail.com>
Date: Thu, 7 Oct 2010 21:52:18 +0000 (+0000)
Subject: Fix an infinite loop, caused by unintended syntax bug (the 'break;' after 'default... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=63b57aeeebb5bb758ecebf9b41b5131781f32bf3;p=clang

Fix an infinite loop, caused by unintended syntax bug (the 'break;' after 'default:' was intended to break out of the while loop).
Fixes rdar://8518859&8520617.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@115985 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp
index e79b639229..ae2fef21c4 100644
--- a/lib/Sema/SemaChecking.cpp
+++ b/lib/Sema/SemaChecking.cpp
@@ -2454,14 +2454,10 @@ static bool IsZero(Sema &S, Expr *E) {
 static bool HasEnumType(Expr *E) {
   // Strip off implicit integral promotions.
   while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
-    switch (ICE->getCastKind()) {
-    case CK_IntegralCast:
-    case CK_NoOp:
-      E = ICE->getSubExpr();
-      continue;
-    default:
+    if (ICE->getCastKind() != CK_IntegralCast &&
+        ICE->getCastKind() != CK_NoOp)
       break;
-    }
+    E = ICE->getSubExpr();
   }
 
   return E->getType()->isEnumeralType();
diff --git a/test/SemaCXX/type-dependent-exprs.cpp b/test/SemaCXX/type-dependent-exprs.cpp
index abe1b4d730..37d7cee881 100644
--- a/test/SemaCXX/type-dependent-exprs.cpp
+++ b/test/SemaCXX/type-dependent-exprs.cpp
@@ -22,3 +22,14 @@ T f(T x) {
   h(1); // expected-error{{use of undeclared identifier 'h'}}
   return 0;
 }
+
+// This one entered into an infinite loop.
+template <unsigned long N>
+void rdar8520617() {
+  if (N > 1) { } // expected-warning {{comparison of 0 > unsigned expression is always false}}
+}
+
+int f2() {
+  rdar8520617<0>(); // expected-note {{in instantiation}}
+}
+