From: Brian Behlendorf <behlendorf1@llnl.gov>
Date: Wed, 18 Feb 2009 18:16:26 +0000 (-0800)
Subject: Coverity 9657: Resource Leak
X-Git-Tag: spl-0.4.3~22
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=63a93055fb6cfddebe31c791f7df86b14942ca9d;p=spl

Coverity 9657: Resource Leak

Accidentally leaked list item li in error path.  The fix is to
adjust this error path to ensure the allocated list item which
has not yet been added to the list gets freed.  To do this we
simply add a new goto label slightly earlier to use the existing
cleanup logic and minimize the number of unique return points.
---

diff --git a/module/splat/splat-list.c b/module/splat/splat-list.c
index 464a457..5a610ce 100644
--- a/module/splat/splat-list.c
+++ b/module/splat/splat-list.c
@@ -380,7 +380,7 @@ splat_list_test7(struct file *file, void *arg)
 			    "list node should inactive %p/%p\n",
 			    li->li_node.prev, li->li_node.next);
 		rc = -EINVAL;
-		goto out;
+		goto out_li;
 	}
 
 	/* Validate node is active when linked in to a list */
@@ -403,7 +403,7 @@ splat_list_test7(struct file *file, void *arg)
 			    li->li_node.prev, li->li_node.next);
 		rc = -EINVAL;
 	}
-
+out_li:
 	kmem_free(li, sizeof(list_item_t));
 out:
 	/* Remove all items */