From: Artem Belevich <tra@google.com> Date: Tue, 23 Jan 2018 19:08:18 +0000 (+0000) Subject: [CUDA] CUDA has no device-side library builtins. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=639c532fba3e862f87c1fe66b7b638169632e233;p=clang [CUDA] CUDA has no device-side library builtins. We should (almost) never consider a device-side declaration to match a library builtin functio. Otherwise clang may ignore the implementation provided by the CUDA headers and emit clang's idea of the builtin. Differential Revision: https://reviews.llvm.org/D42319 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@323239 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp index 918466236b..f8010695c9 100644 --- a/lib/AST/Decl.cpp +++ b/lib/AST/Decl.cpp @@ -2901,6 +2901,13 @@ unsigned FunctionDecl::getBuiltinID() const { Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID)) return 0; + // CUDA does not have device-side standard library. printf and malloc are the + // only special cases that are supported by device-side runtime. + if (Context.getLangOpts().CUDA && hasAttr<CUDADeviceAttr>() && + !hasAttr<CUDAHostAttr>() && + !(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc)) + return 0; + return BuiltinID; } diff --git a/test/CodeGenCUDA/library-builtin.cu b/test/CodeGenCUDA/library-builtin.cu new file mode 100644 index 0000000000..4804c75cde --- /dev/null +++ b/test/CodeGenCUDA/library-builtin.cu @@ -0,0 +1,22 @@ +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -o - %s | \ +// RUN: FileCheck --check-prefixes=HOST,BOTH %s +// RUN: %clang_cc1 -fcuda-is-device -triple nvptx64-nvidia-cuda \ +// RUN: -emit-llvm -o - %s | FileCheck %s --check-prefixes=DEVICE,BOTH + +// BOTH-LABEL: define float @logf(float + +// logf() should be calling itself recursively as we don't have any standard +// library on device side. +// DEVICE: call float @logf(float +extern "C" __attribute__((device)) float logf(float __x) { return logf(__x); } + +// NOTE: this case is to illustrate the expected differences in behavior between +// the host and device. In general we do not mess with host-side standard +// library. +// +// Host is assumed to have standard library, so logf() calls LLVM intrinsic. +// HOST: call float @llvm.log.f32(float +extern "C" float logf(float __x) { return logf(__x); }