From: Mike Stump <mrs@apple.com>
Date: Sat, 7 Mar 2009 06:16:52 +0000 (+0000)
Subject: Remove last FIXME for block literal codegen that I know about and turn
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=63822bab6e76041b623204566c9ea657023315b0;p=clang

Remove last FIXME for block literal codegen that I know about and turn
on all the new code by default.  There is still plenty of testing to
do and issues I'm sure need resolving.  Let me know if you find
anything.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@66323 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CGBlocks.cpp b/lib/CodeGen/CGBlocks.cpp
index 4e4698273f..9e3c4519cf 100644
--- a/lib/CodeGen/CGBlocks.cpp
+++ b/lib/CodeGen/CGBlocks.cpp
@@ -31,7 +31,7 @@ Enable__block("f__block",
                              "even though the code isn't done yet"),
               llvm::cl::ValueDisallowed, llvm::cl::AllowInverse,
               llvm::cl::ZeroOrMore,
-              llvm::cl::init(false));
+              llvm::cl::init(true));
 
 llvm::Constant *CodeGenFunction::
 BuildDescriptorBlockDecl(uint64_t Size, const llvm::StructType* Ty,
@@ -479,7 +479,6 @@ llvm::Value *CodeGenFunction::GetAddrOfBlockDecl(const BlockDeclRefExpr *E) {
   const llvm::Type *Ty;
   Ty = CGM.getTypes().ConvertType(E->getDecl()->getType());
 
-  // FIXME: add support for copy/dispose helpers.
   if (!Enable__block && E->isByRef())
     ErrorUnsupported(E, "__block variable in block literal");
   else if (!Enable__block && E->getType()->isBlockPointerType())